Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Store flowinfo/scope_id in host byte order #32429

Merged
merged 1 commit into from
Mar 23, 2016

Conversation

alexcrichton
Copy link
Member

Apparently these aren't supposed to be stored in network byte order, so doing so
ends up causing failures when it would otherwise succeed when stored in the host
byte order.

Closes #32424

Apparently these aren't supposed to be stored in network byte order, so doing so
ends up causing failures when it would otherwise succeed when stored in the host
byte order.

Closes rust-lang#32424
@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon
Copy link
Member

aturon commented Mar 22, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 22, 2016

📌 Commit 88506ce has been approved by aturon

@eddyb
Copy link
Member

eddyb commented Mar 23, 2016

@bors rollup

@tamird
Copy link
Contributor

tamird commented Mar 23, 2016

Hm, no test?

eddyb added a commit to eddyb/rust that referenced this pull request Mar 23, 2016
std: Store flowinfo/scope_id in host byte order

Apparently these aren't supposed to be stored in network byte order, so doing so
ends up causing failures when it would otherwise succeed when stored in the host
byte order.

Closes rust-lang#32424
@alexcrichton
Copy link
Member Author

I would! but I wasn't sure how :(

@tamird
Copy link
Contributor

tamird commented Mar 23, 2016

Couldn't you use the code sample from #32424 verbatim?

use std::net::{SocketAddr, SocketAddrV6, UdpSocket};

fn main() {
    let socket = UdpSocket::bind(&SocketAddr::V6(SocketAddrV6::new("fe80::1".parse().unwrap(), 0xfc00, 0, 2))).unwrap();
}

@alexcrichton
Copy link
Member Author

I tried that locally, yes, but it was failing as the arguments are system specific (talking bout specific interfaces here and there)

bors added a commit that referenced this pull request Mar 23, 2016
Rollup of 11 pull requests

- Successful merges: #32404, #32420, #32423, #32425, #32429, #32430, #32431, #32434, #32437, #32441, #32443
- Failed merges:
@bors bors merged commit 88506ce into rust-lang:master Mar 23, 2016
@alexcrichton alexcrichton deleted the scope-id-hton branch March 27, 2016 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants