Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsound behaviour with null characters in thread names (issue #32475) #32476

Merged
merged 1 commit into from
Mar 26, 2016

Commits on Mar 25, 2016

  1. Fix unsound behaviour with null characters in thread names (issue rus…

    …t-lang#32475)
    
    Previously, the thread name (&str) was converted to a CString in the
    new thread, but outside unwind::try, causing a panic to continue into FFI.
    
    This patch changes that behaviour, so that the panic instead happens
    in the parent thread (where panic infrastructure is properly set up),
    not the new thread.
    
    This could potentially be a breaking change for architectures who don't
    support thread names.
    
    Signed-off-by: David Henningsson <diwic@ubuntu.com>
    diwic committed Mar 25, 2016
    Configuration menu
    Copy the full SHA
    78495d5 View commit details
    Browse the repository at this point in the history