Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accommodate the case where dup lang items are entirely external. #32970

Merged
merged 1 commit into from
Apr 16, 2016
Merged

Accommodate the case where dup lang items are entirely external. #32970

merged 1 commit into from
Apr 16, 2016

Conversation

taralx
Copy link
Contributor

@taralx taralx commented Apr 14, 2016

Fixes #32961

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ 37e59b9

@Manishearth Manishearth mentioned this pull request Apr 15, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 15, 2016
@Manishearth
Rollup merge of rust-lang#32970 - taralx:patch-2, r=alexcrichton
00d4ac3 
Accommodate the case where dup lang items are entirely external.

Fixes rust-lang#32961
bors added a commit that referenced this pull request Apr 15, 2016
@bors
Auto merge of #33005 - Manishearth:rollup, r=Manishearth
576229f 
Rollup of 11 pull requests

- Successful merges: #32923, #32926, #32929, #32931, #32935, #32945, #32946, #32964, #32970, #32973, #32997
- Failed merges:
@bors bors merged commit 37e59b9 into rust-lang:master Apr 16, 2016
@taralx taralx deleted the patch-2 branch May 25, 2016 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aatch Aatch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taralx @rust-highfive @alexcrichton @Aatch @bors