-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustbuild: Package librustc & co for cross-hosts #33011
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Currently the `rust-std` package produced by rustbuild only contains the standard library plus libtest, but the makefiles actually produce a `rust-std` package with all known target libraries (including libsyntax, librustc, etc). Tweak the behavior so the dependencies of the `dist-docs` step in rustbuild depend on the compiler libraries as well (so that they're all packaged). Closes rust-lang#32984
3c81ecb
to
6ff8f4a
Compare
How about splitting the std component into a "new" std component (only libstd + its deps + libtest) and an "extra" component (libsyntax + rustc crates) with the goal of making the later opt-in (cc rust-lang/rustup#298) to reduce bandwidth/disk usage? I suspect most people won't use the rustc internals in their crates, and there is |
Yeah I think that makes sense long term! |
@bors r+ |
📌 Commit 6ff8f4a has been approved by |
rustbuild: Package librustc & co for cross-hosts Currently the `rust-std` package produced by rustbuild only contains the standard library plus libtest, but the makefiles actually produce a `rust-std` package with all known target libraries (including libsyntax, librustc, etc). Tweak the behavior so the dependencies of the `dist-docs` step in rustbuild depend on the compiler libraries as well (so that they're all packaged). Closes #32984
💔 Test failed - auto-win-msvc-32-opt |
@bors: retry On Wed, Apr 20, 2016 at 4:12 PM, bors notifications@github.com wrote:
|
Currently the
rust-std
package produced by rustbuild only contains thestandard library plus libtest, but the makefiles actually produce a
rust-std
package with all known target libraries (including libsyntax, librustc, etc).
Tweak the behavior so the dependencies of the
dist-docs
step in rustbuilddepend on the compiler libraries as well (so that they're all packaged).
Closes #32984