Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: Package librustc & co for cross-hosts #33011

Merged
merged 1 commit into from
Apr 21, 2016

Conversation

alexcrichton
Copy link
Member

Currently the rust-std package produced by rustbuild only contains the
standard library plus libtest, but the makefiles actually produce a rust-std
package with all known target libraries (including libsyntax, librustc, etc).
Tweak the behavior so the dependencies of the dist-docs step in rustbuild
depend on the compiler libraries as well (so that they're all packaged).

Closes #32984

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

Currently the `rust-std` package produced by rustbuild only contains the
standard library plus libtest, but the makefiles actually produce a `rust-std`
package with all known target libraries (including libsyntax, librustc, etc).
Tweak the behavior so the dependencies of the `dist-docs` step in rustbuild
depend on the compiler libraries as well (so that they're all packaged).

Closes rust-lang#32984
@japaric
Copy link
Member

japaric commented Apr 15, 2016

How about splitting the std component into a "new" std component (only libstd + its deps + libtest) and an "extra" component (libsyntax + rustc crates) with the goal of making the later opt-in (cc rust-lang/rustup#298) to reduce bandwidth/disk usage? I suspect most people won't use the rustc internals in their crates, and there is syntex_syntax to cover their syntax extension/parsing needs.

@alexcrichton
Copy link
Member Author

Yeah I think that makes sense long term!

@brson
Copy link
Contributor

brson commented Apr 19, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Apr 19, 2016

📌 Commit 6ff8f4a has been approved by brson

@bors
Copy link
Contributor

bors commented Apr 20, 2016

⌛ Testing commit 6ff8f4a with merge 95545e7...

bors added a commit that referenced this pull request Apr 20, 2016
rustbuild: Package librustc & co for cross-hosts

Currently the `rust-std` package produced by rustbuild only contains the
standard library plus libtest, but the makefiles actually produce a `rust-std`
package with all known target libraries (including libsyntax, librustc, etc).
Tweak the behavior so the dependencies of the `dist-docs` step in rustbuild
depend on the compiler libraries as well (so that they're all packaged).

Closes #32984
@bors
Copy link
Contributor

bors commented Apr 20, 2016

💔 Test failed - auto-win-msvc-32-opt

@alexcrichton
Copy link
Member Author

@bors: retry

On Wed, Apr 20, 2016 at 4:12 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-msvc-32-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-32-opt/builds/3079


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#33011 (comment)

@bors bors merged commit 6ff8f4a into rust-lang:master Apr 21, 2016
@alexcrichton alexcrichton deleted the pkg-everything branch May 2, 2016 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants