Add armv7-linux-androideabi target #33414
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -12,7 +12,7 @@ use target::Target; | |||
|
|
|||
| pub fn target() -> Target { | |||
| let mut base = super::android_base::opts(); | |||
| base.features = "+v7,+vfp3,+d16".to_string(); | |||
| base.features = "+v6".to_string(); | |||
There was a problem hiding this comment.
Could this target temporarily stay where it is today for now? We'd like to give a window of time for projects to move over to the armv7 target before we downgrade the arm one. I don't believe we've received a request yet to use arm instead of armv7, so it's not super pressing to do so just yet
|
Thanks @Nercury! Just one nit about not changing arm for now (we can do that once armv7 has nightlies and such), but other than that looks good to me |
|
Changes to current I also saw few tests using current |
alexcrichton
added
the
relnotes
|
@bors: r+ a9a5a52be5d077e402b7cc029b62d8b5c44c1519
Probably, yeah. |
|
☔ The latest upstream changes (presumably #33228) made this pull request unmergeable. Please resolve the merge conflicts. |
|
(I am not sure if this comment was necessary) |
Add armv7-linux-androideabi target This PR adds `armv7-linux-androideabi` target that matches `armeabi-v7a` Android ABI, ~~downscales `arm-linux-androideabi` target to match `armeabi` Android ABI~~ (TBD later if needed). This should allow us to get the best performance from every [Android ABI level](http://developer.android.com/ndk/guides/abis.html). Currently existing target `arm-linux-androideabi` started gaining features out of the supported range of [android `armeabi`](http://developer.android.com/ndk/guides/abis.html). While android compiler does not use a different target for later supported `armv7` architecture, it has distinct ABI name `armeabi-v7a`. We decided to add rust target `armv7-linux-androideabi` to match it. Note that `NEON`, `VFPv3-D32`, and `ThumbEE` instruction sets are not added, because not all android devices are guaranteed to support all or some of these, and [their availability should be checked at runtime](http://developer.android.com/ndk/guides/abis.html#v7a). ~~This reduces performance of existing `arm-linux-androideabi` and may make it _much_ slower (we are talking more than order of magnitude in some random ad-hoc fp benchmark that I did).~~ Part of #33278.
This PR adds
armv7-linux-androideabitarget that matchesarmeabi-v7aAndroid ABI,downscales(TBD later if needed).arm-linux-androideabitarget to matcharmeabiAndroid ABIThis should allow us to get the best performance from every Android ABI level.
Currently existing target
arm-linux-androideabistarted gaining features out of the supported range of androidarmeabi. While android compiler does not use a different target for later supportedarmv7architecture, it has distinct ABI namearmeabi-v7a. We decided to add rust targetarmv7-linux-androideabito match it.Note that
NEON,VFPv3-D32, andThumbEEinstruction sets are not added, because not all android devices are guaranteed to support all or some of these, and their availability should be checked at runtime.This reduces performance of existingarm-linux-androideabiand may make it much slower (we are talking more than order of magnitude in some random ad-hoc fp benchmark that I did).Part of #33278.