Added help for eof message inside macro invocation #33963
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| self.this_token_descr()); | ||
| return Err(self.span_fatal_help( | ||
| self.span, &msg, &help)); | ||
| } |
There was a problem hiding this comment.
You cannot know here that you are parsing the arguments of a macro invocation. I suspect that the following code:
static foo: u32 =will trigger your error message. Which is obviously not what you want.
Besides, your code only handles the case where the macro parsing reaches EOF while trying to parse an expr. Thing is, macros can parse a lot of different fragments of Rust syntax and match arbitrary Rust tokens. So there are a lot of other places where you should handle this as well. As far as I know, it's not possible to handle them all because for those who use the Rust parser (like expr), you cannot know if you are parsing a macro invocation or not.
Maybe the easier solution would be to introduce a special token to indicate end of macro invocation that would behave like EOF except for error messages but that would be a lot of changes just to add an help message.
There was a problem hiding this comment.
Maybe the easier solution would be to introduce a special token to indicate end of macro invocation that would behave like EOF except for error messages but that would be a lot of changes just to add an help message.
This seems like a good idea to me, too.
|
Since it's been a little while, I'm going to close this PR, just to help clear out the queue of work. I do think it's important to resolve the problems that @LeoTestard pointed out here before trying to land this. @gchp please feel free to re-open if you have a chance to make progress on that front! Thanks. :) |
Fixes #27569