-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid inlining #34234
Fix invalid inlining #34234
Conversation
Do we know what change caused this regression? I'd rather undo whatever broke it then add more stuff on top. |
I have no idea. But it seems strange that it worked. |
2b7deda
to
7cd8912
Compare
@GuillaumeGomez see my comment here |
@est31: It matches what I found, so that's why I think just fixing it like this might be better. |
@sanxiyn: In this PR, it's still a table. |
@GuillaumeGomez I don't understand what you are saying. I see no |
Oh sorry. I thought you said that #33867 removed the Anyway, I don't understand why we'd need a |
@steveklabnik asked what change caused this regression, so I answered it is #33867. Yes, I am saying that #33867 removed |
It should probably be a Edit: |
@nox: It'll be part of a big HTML/CSS refactor. |
Okay. I think, given all this, adding a small hack is better, given that the regression has already landed. This isn't the worst thing in the world. @bors: r+ |
📌 Commit 7cd8912 has been approved by |
Fix invalid inlining r? @steveklabnik So to put a context. @nox found an issue on the generated doc: ![screenshot from 2016-06-11 19-53-38](https://cloud.githubusercontent.com/assets/3050060/15987898/f7341de0-303b-11e6-9cd7-f2a6df423ee7.png) So as you can see, the two variants are on the same where they shouldn't. I found out that the issue is also on structs: ![screenshot from 2016-06-11 19-53-31](https://cloud.githubusercontent.com/assets/3050060/15987900/0f66c5de-303c-11e6-90fc-5e49d11b6903.png) And so such is the result of the PR: ![screenshot from 2016-06-12 01-15-21](https://cloud.githubusercontent.com/assets/3050060/15987904/19d9183c-303c-11e6-91c1-7c3f1163fbb0.png) ![screenshot from 2016-06-12 01-15-24](https://cloud.githubusercontent.com/assets/3050060/15987905/1b5d2db0-303c-11e6-8f43-9a8ad2371007.png)
rustdoc: Fix search result layout for enum variants and struct fields This was broken in #34234. For example: [before](https://doc.rust-lang.org/nightly/std/?search=cow%3A%3Aborrowed) [after](https://ollie27.github.io/rust_doc_test/std/?search=cow%3A%3Aborrowed) [before](https://doc.rust-lang.org/nightly/std/?search=range%3A%3Astart) [after](https://ollie27.github.io/rust_doc_test/std/?search=range%3A%3Astart) cc @GuillaumeGomez
r? @steveklabnik
So to put a context. @nox found an issue on the generated doc:
So as you can see, the two variants are on the same where they shouldn't. I found out that the issue is also on structs:
And so such is the result of the PR: