Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cfg_attr on path attributes #34546

Merged
merged 2 commits into from
Jul 6, 2016
Merged

Support cfg_attr on path attributes #34546

merged 2 commits into from
Jul 6, 2016

Conversation

jseyfried
Copy link
Contributor

@jseyfried jseyfried commented Jun 29, 2016 •
edited
Loading

Fixes #25544.
This is technically a [breaking-change]. For example, the following would break:

#[cfg_attr(all(), path = "nonsense.rs")]
mod foo; // Suppose `foo.rs` existed in the appropriate location

@nagisa
Copy link
Member

nagisa commented Jun 29, 2016

cc @rust-lang/lang

@eddyb
Copy link
Member

eddyb commented Jun 29, 2016

Crater report shows only 2 false positives, no relevant regressions.

@jseyfried
Copy link
Contributor Author

@eddyb Excellent!

@jseyfried
Copy link
Contributor Author

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned eddyb Jul 5, 2016
@nrc
Copy link
Member

nrc commented Jul 5, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 5, 2016

📌 Commit 2ef02e1 has been approved by nrc

@bors
Copy link
Contributor

bors commented Jul 6, 2016

⌛ Testing commit 2ef02e1 with merge 11bca98...

@bors
Copy link
Contributor

bors commented Jul 6, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@jseyfried
Copy link
Contributor Author

@bors r=nrc

@bors
Copy link
Contributor

bors commented Jul 6, 2016

📌 Commit ba59d42 has been approved by nrc

@bors
Copy link
Contributor

bors commented Jul 6, 2016

⌛ Testing commit ba59d42 with merge 4738076...

bors added a commit that referenced this pull request Jul 6, 2016
@bors
Auto merge of #34546 - jseyfried:cfg_attr_path, r=nrc
4738076 
Support `cfg_attr` on `path` attributes

Fixes #25544.
This is technically a [breaking-change]. For example, the following would break:
```rust
mod foo; // Suppose `foo.rs` existed in the appropriate location
```
@bors
Copy link
Contributor

bors commented Jul 6, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing 4738076 to master...

@bors bors merged commit ba59d42 into rust-lang:master Jul 6, 2016
@jseyfried jseyfried deleted the cfg_attr_path branch September 14, 2016 21:20
@baumanj baumanj mentioned this pull request May 14, 2019
Merged
Centril added a commit to Centril/rust that referenced this pull request Mar 22, 2020
@Centril
Rollup merge of rust-lang#70253 - jplatte:patch-2, r=Mark-Simulacrum
8406150 
Remove another wrong entry from RELEASES.md

The entry is under 1.11.0, but the feature is only available since 1.12.0 (for which an identical entry exists).

![Screenshot_2020-03-22 Support `cfg_attr` on `path` attributes by jseyfried · Pull Request rust-lang#34546 · rust-lang rust](https://user-images.githubusercontent.com/951129/77238862-85c8f580-6bd4-11ea-8d31-77e2994a4b5a.png)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 22, 2020
@Dylan-DPC
Rollup merge of rust-lang#70253 - jplatte:patch-2, r=Mark-Simulacrum
e5d3476 
Remove another wrong entry from RELEASES.md

The entry is under 1.11.0, but the feature is only available since 1.12.0 (for which an identical entry exists).

![Screenshot_2020-03-22 Support `cfg_attr` on `path` attributes by jseyfried · Pull Request rust-lang#34546 · rust-lang rust](https://user-images.githubusercontent.com/951129/77238862-85c8f580-6bd4-11ea-8d31-77e2994a4b5a.png)
@hydra hydra mentioned this pull request May 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jseyfried @nagisa @eddyb @nrc @bors