Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update underscore usage (#34903) #34990

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Update underscore usage (#34903) #34990

merged 1 commit into from
Jul 27, 2016

Conversation

abhijeetbhagat
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Jul 25, 2016

📌 Commit 6ebe6e8 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 25, 2016
@steveklabnik
Rollup merge of rust-lang#34990 - abhijeetbhagat:patch-3, r=steveklabnik
4d44503 
Update underscore usage (rust-lang#34903)
@steveklabnik steveklabnik mentioned this pull request Jul 25, 2016
Closed
bors added a commit that referenced this pull request Jul 25, 2016
@bors
Auto merge of #35036 - steveklabnik:rollup, r=steveklabnik
c513608 
Rollup of 13 pull requests

- Successful merges: #34461, #34609, #34732, #34850, #34894, #34935, #34974, #34990, #34995, #35001, #35009, #35010, #35028
- Failed merges:
@bors
Copy link
Contributor

bors commented Jul 26, 2016

⌛ Testing commit 6ebe6e8 with merge 3c309f3...

@bors
Copy link
Contributor

bors commented Jul 26, 2016

💔 Test failed - auto-win-msvc-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Jul 26, 2016 at 4:23 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/5091

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34990 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95K8hfW6goxE6eMLdK03ivZtuK5uPks5qZe5KgaJpZM4JTUOD
.

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 26, 2016
@steveklabnik
Rollup merge of rust-lang#34990 - abhijeetbhagat:patch-3, r=steveklabnik
96108bb 
Update underscore usage (rust-lang#34903)
@steveklabnik steveklabnik mentioned this pull request Jul 26, 2016
Merged
bors added a commit that referenced this pull request Jul 27, 2016
@bors
Auto merge of #35053 - steveklabnik:rollup, r=steveklabnik
edecc57 
Rollup of 15 pull requests

- Successful merges: #34461, #34609, #34732, #34850, #34935, #34974, #34990, #34995, #35001, #35009, #35010, #35019, #35028, #35029, #35043
- Failed merges:
@bors bors merged commit 6ebe6e8 into rust-lang:master Jul 27, 2016
@kyrias kyrias mentioned this pull request Aug 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abhijeetbhagat @rust-highfive @steveklabnik @bors @alexcrichton