Add non-panicking abs() functions to all signed integer types. #35058
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| /// ``` | ||
| #[unstable(feature = "no_panic_abs", issue = "35057")] | ||
| #[inline] | ||
| pub fn overflowing_abs(self) -> (Self,bool) { |
There was a problem hiding this comment.
There should be a space after the ,.
| if self.is_negative() { | ||
| self.overflowing_neg() | ||
| } else { | ||
| self |
There was a problem hiding this comment.
This should probably be (self, false).
|
@bors: r+ bdd6a11f0e636daff50075360180989144879fff |
|
@bors r- Documentation test failed in rollup. You need to add |
|
thanks, @sanxiyn |
Currently, calling abs() on one of the signed integer types might panic (in debug mode at least) because the absolute value of the largest negative value can not be represented in that signed type. Unlike all other integer operations, there is currently not a non-panicking version on this function. This seems to just be an oversight in the design, therefore just adding it now.
|
Fixed and rebased |
|
@bors: rollup assuming this isn't very platform-specific and green travis means it's good to go whenever |
Add non-panicking abs() functions to all signed integer types. Currently, calling abs() on one of the signed integer types might panic (in debug mode at least) because the absolute value of the largest negative value can not be represented in that signed type. Unlike all other integer operations, there is currently not a non-panicking version on this function. This seems to just be an oversight in the design, therefore just adding it now.
Add non-panicking abs() functions to all signed integer types. Currently, calling abs() on one of the signed integer types might panic (in debug mode at least) because the absolute value of the largest negative value can not be represented in that signed type. Unlike all other integer operations, there is currently not a non-panicking version on this function. This seems to just be an oversight in the design, therefore just adding it now.
Currently, calling abs() on one of the signed integer types might panic (in
debug mode at least) because the absolute value of the largest negative value
can not be represented in that signed type. Unlike all other integer
operations, there is currently not a non-panicking version on this function.
This seems to just be an oversight in the design, therefore just adding it now.