-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #35100
Merged
Merged
Rollup of 7 pull requests #35100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand the "nullable pointer optimization" section with a code example. Change examples to use std::os::raw instead of libc, when applicable.
Not sure the example is going to stay, but I can try to pass Travis for the bragging rights.
…ype, even though that is how it works
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ p=1 |
📌 Commit 271d977 has been approved by |
⌛ Testing commit 271d977 with merge 79c7433... |
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
book/ffi: nullable pointer cleanup Expand the "nullable pointer optimization" section with a code example. Fixes rust-lang#34250. I also noticed that many of the examples use the libc crate just for types such as `c_char` and `c_int`, which are now available through `std::os::raw`. I changed the ones that don't need to rely on libc. I'm glad to revert that part of the commit if it's unwanted churn.
…abnik More intuitive explantion of strings formatting
…omez Add documentation example for `str::Chars::as_str`. None
Update docs for assert! and debug_assert! Refer to rust-lang#34455
Try to clear up some awkward wording
@bors: r+ p=1 |
📌 Commit 5f5fdf6 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
str::Chars::as_str
. #35062, Fix typos #35066, Update docs for assert! and debug_assert! #35072, Fs docs #35087