-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E0005 to use a label #35731
Update E0005 to use a label #35731
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the PR! Looking good so far. You'll next need to update the unit test to check for the label. There's a quirk in the unit tester in that it will only tests a label if you add at least one NOTE to the unit test. I talk about it in the blog post in the Extra Credit section. With the unit test updated, we should be good to go. |
Looks good! @bors r+ rollup |
📌 Commit 4cfdf63 has been approved by |
Update E0005 to use a label Fixes rust-lang#35192 as Part of rust-lang#35233 r? @jonathandturner
Update E0005 to use a label Fixes rust-lang#35192 as Part of rust-lang#35233 r? @jonathandturner
Fixes #35192 as Part of #35233
r? @jonathandturner