Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0005 to use a label #35731

Merged
merged 2 commits into from
Aug 17, 2016
Merged

Update E0005 to use a label #35731

merged 2 commits into from
Aug 17, 2016

Conversation

pythoneer
Copy link
Contributor

Fixes #35192 as Part of #35233

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

Thanks for the PR!

Looking good so far. You'll next need to update the unit test to check for the label. There's a quirk in the unit tester in that it will only tests a label if you add at least one NOTE to the unit test. I talk about it in the blog post in the Extra Credit section.

With the unit test updated, we should be good to go.

@sophiajt
Copy link
Contributor

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 16, 2016

📌 Commit 4cfdf63 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
bors added a commit that referenced this pull request Aug 17, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
bors added a commit that referenced this pull request Aug 17, 2016
@bors bors merged commit 4cfdf63 into rust-lang:master Aug 17, 2016
@pythoneer pythoneer deleted the fix-35192 branch August 17, 2016 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants