-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ICE test in compiletest fail-tests #36335
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ rollup |
📌 Commit dd6e386 has been approved by |
@mcarton good catch =) |
⌛ Testing commit dd6e386 with merge 5df533b... |
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
@bors: retry On Tue, Sep 13, 2016 at 8:30 PM, bors notifications@github.com wrote:
|
It made an ICE it seems: https://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/10480/steps/test/logs/stdio |
@bors: rollup- |
Looks weird to check for the presence of an ICE. |
It sounds to me like the desired error is being reported and then, On Sep 14, 2016 12:27 PM, "Martin Carton" notifications@github.com wrote:
|
⌛ Testing commit dd6e386 with merge a0473dc... |
💔 Test failed - auto-mac-32-opt |
I've changed the error so that it does not ICE anymore. |
But it still fails travis. :p |
This once, I've tested it 😅 |
And travis seems happy. All good for me then. Thanks! @bors: r+ rollup |
📌 Commit bfa3433 has been approved by |
Fix ICE test in compiletest fail-tests While working on Clippy which uses *compiletest*, I noticed that as long as all expected error are found, *compile-fail* tests will be marked *ok* even if there is an ICE. One function seems to have not been updated with JSON errors because ICEs are now reported like this: ```json {"message":"../src/librustc/ty/context.rs:161: Attempted to intern `_` which contains inference types/regions in the global type context","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":null} ``` I don't think I can add a test for that. I guess: r? @nikomatsakis
I only now saw this PR. When I introduced that test in #31410 I was told to make it a |
While working on Clippy which uses compiletest, I noticed that as long as all expected error are found, compile-fail tests will be marked ok even if there is an ICE. One function seems to have not been updated with JSON errors because ICEs are now reported like this:
I don't think I can add a test for that.
I guess:
r? @nikomatsakis