Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use adt::trans_const when translating constant closures and tuples #36406

Merged
merged 1 commit into from
Sep 12, 2016
Merged

use adt::trans_const when translating constant closures and tuples #36406

merged 1 commit into from
Sep 12, 2016

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Sep 11, 2016 •
edited
Loading

The previous way dropped padding on the floor.

Fixes #36401

r? @eddyb

@arielb1 arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 11, 2016
@arielb1
Copy link
Contributor Author

arielb1 commented Sep 11, 2016

beta-nominated since regression.

@eddyb
Copy link
Member

eddyb commented Sep 12, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Sep 12, 2016

📌 Commit f1bd907 has been approved by eddyb

@bors
Copy link
Contributor

bors commented Sep 12, 2016

⌛ Testing commit f1bd907 with merge 85592fb...

bors added a commit that referenced this pull request Sep 12, 2016
@bors
Auto merge of #36406 - arielb1:constant-padding, r=eddyb
85592fb 
use `adt::trans_const` when translating constant closures and tuples

The previous way dropped padding on the floor.

Fixes #36401

r? @eddyb
@bors
Copy link
Contributor

bors commented Sep 12, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 85592fb to master...

@bors bors merged commit f1bd907 into rust-lang:master Sep 12, 2016
@bors bors mentioned this pull request Sep 12, 2016
Merged
@nikomatsakis
Copy link
Contributor

Accepting for beta. Relatively small patch, regression. But I encourage @rust-lang/compiler people to take a look.

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 19, 2016
@brson brson mentioned this pull request Sep 19, 2016
Merged
@pnkfelix pnkfelix mentioned this pull request Sep 21, 2016
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arielb1 @eddyb @bors @nikomatsakis @brson