Make E0243/E0244 message consistent with E0107 #36615
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
There's one more inconsistency! |
sinkuu
changed the title
|
Currently documentations and compiler messages don't tell lifetime arguments/parameters apart (they seem to be called "parameters" everywhere). |
|
☔ The latest upstream changes (presumably #36862) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This looks close, but as @petrochenkov points out both should be arguments since they are calls. Also this is confusing: You're underlining 2 arguments and saying that's what you expect. How is this an error? |
|
|
|
@sinkuu do you have an updated example of what it will look like? |
|
Ah in that case perhaps it should note the difference. I totally overlooked it |
|
I'll try to do that. |
|
☔ The latest upstream changes (presumably #37269) made this pull request unmergeable. Please resolve the merge conflicts. |
sinkuu
force-pushed
the
e0243_0244
branch
2 times, most recently
from
3cf465d to
94a896f
Compare
|
Converted "lifetime parameters" to "lifetime arguments". For noting differences between lifetime args and type args, I'm not sure what the note should say. When types are mixed-up with lifetimes, the compiler will put both E0107 and E0244 anyway.gi |
|
Hmm I'm of two minds about whether to say "arguments" or "parameters". A quick google search suggests that most people say "generic type parameters" (C#, Java), though there are some who say "arguments" (TypeScript). Definitely searching for "generic type parameters" gives a lot more results (1.6mil) than "generic type arguments (670k, the top few of which are actually saying "parameters"). I definitely agree consistency is better though. =) |
|
+1 for parameters |
|
The debate about "arguments" vs "parameters" seems to transcend this PR. Can we just press on as-is? |
|
@brson agreed, this PR just keeps existing language it seems |
|
In that sense, ping r? @nrc for helping to move forward |
|
@bors: r+ |
|
📌 Commit 12f0b6f has been approved by |
Make E0243/E0244 message consistent with E0107
E0243/E0233 prints `expected {}, found {}` on the span note, while E0107 prints it on the first line. This is confusing when both error occur simultaneously.
This PR makes E0243/E0233 print `expected {}, found {}` on the first line.
Code:
``` rust
struct Foo<'a, 'b> {
s: &'a str,
t: &'b str,
}
type Bar<T, U> = Foo<T, U>;
```
rustc output (before):
```
error[E0107]: wrong number of lifetime parameters: expected 2, found 0
--> test.rs:6:18
|
6 | type Bar<T, U> = Foo<T, U>;
| ^^^^^^^^^ expected 2 lifetime parameters
error[E0244]: wrong number of type arguments
--> test.rs:6:18
|
6 | type Bar<T, U> = Foo<T, U>;
| ^^^^^^^^^ expected no type arguments, found 2
```
rustc output (after):
```
error[E0107]: wrong number of lifetime parameters: expected 2, found 0
--> /tmp/test.rs:6:18
|
6 | type Bar<T, U> = Foo<T, U>;
| ^^^^^^^^^ expected 2 lifetime parameters
error[E0244]: wrong number of type arguments: expected 0, found 2
--> /tmp/test.rs:6:18
|
6 | type Bar<T, U> = Foo<T, U>;
| ^^^^^^^^^ expected no type arguments
```
E0243/E0233 prints
expected {}, found {}on the span note, while E0107 prints it on the first line. This is confusing when both error occur simultaneously.This PR makes E0243/E0233 print
expected {}, found {}on the first line.Code:
rustc output (before):
rustc output (after):