-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #36885
Merged
Merged
Rollup of 6 pull requests #36885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was previously cached and maintained in the `Context`, which to me seems overkill.
Previously the `env!("RUSTC_VERSION")` requirement would break the "Documenting rustc_metadata" stage of the rustc build, since that environment variable is only defined during the main build.
Haiku: Fix target triplet delimiter
A couple refactorings in librustdoc. None
…handturner Update E0035, E0036 and E0370 to new error format Fixes rust-lang#35634. Fixes rust-lang#35206. Fixes rust-lang#35207. r? @jonathandturner
…=eddyb Fix RUSTC_VERSION for 'documenting' build stage. Previously the `env!("RUSTC_VERSION")` requirement would break the "Documenting rustc_metadata" stage of the rustc build, since that environment variable is only defined during the main build. r? @eddyb
impl Debug for raw pointers to unsized data `?Sized` was missing from these impls for seemingly no reason. Fixes rust-lang#36870.
resolve: fix incorrect code in `module_to_string` Fixes rust-lang#36881. r? @nrc or @eddyb
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors p=5 |
@bors r+ |
📌 Commit 8457ab6 has been approved by |
This was referenced Oct 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module_to_string
#36882