-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor modifications in concurrency section of the Rust book #36957
Conversation
between threads, but shared mutable data is unsafe and when threads are | ||
involved can cause data races! | ||
between threads, but shared mutable data is unsafe-and when threads are | ||
involved-can cause data races! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very minor detail, but is it possible you could use the 'dash' character (—) instead of a 'hyphen' character (-) for this?
Minus the punctuation change, looks good to me! |
@frewsxcv Fixed it! |
Strange, it looks like there are two hyphens now. Do you also see that in the diff? |
It appears like that in the diff, but I think the two hyphens are automatically fused together to form a larger hyphen in the actual markdown page. I haven't checked yet. |
I see them as two hyphens as well. Dark magic. |
Fixed it. I was under the impression that the long dash is formed by joining the two small dashes. To rectify this, I actually copied the dash character from here and pasted it in the code because I wasn't able to find a way to type it from my keyboard 😅 |
Looks great, thanks! r=me |
📌 Commit 335d393 has been approved by |
Minor modifications in concurrency section of the Rust book Fixes rust-lang#36939 r? @steveklabnik
Fixes #36939
r? @steveklabnik