macros: persistent scopes #37036
Merged
macros: persistent scopes #37036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
force-pushed
the
persistent_macro_scopes
branch
from
067d2ed to
210b74a
Compare
jseyfried
force-pushed
the
persistent_macro_scopes
branch
from
210b74a to
53fd3b0
Compare
nrc
reviewed
Oct 11, 2016
| MacroRules(ast::Name, Rc<SyntaxExtension>, Span), | ||
| MacroUse(LegacyImports), | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you document these data structures please? In particular, what legacy means, why they need different semantics, and how these structures cause those semantics to happen.
|
Do we need some tests for the shadowing behaviour? r=me with the requested comments and possibly tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groundwork for macro modularization (cc #35896).
r? @nrc