Add some more repos to cargotest #37149

edunham · 2016-10-13T18:03:36Z

From suggestions at https://users.rust-lang.org/t/what-stable-rust-applications-do-you-use-frequently/7618

This adds some applications which use stable Rust and come with their own lockfiles in their respective trees.

ripgrep, xsv, and bins have 33 unique dependencies between them.

I alphabetized the list by project name because that seems tidier.

rust-highfive · 2016-10-13T18:03:50Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

alexcrichton · 2016-10-13T18:24:56Z

@bors: r+

bors · 2016-10-13T18:24:57Z

📌 Commit 4f71566 has been approved by alexcrichton

jonas-schievink · 2016-10-13T18:42:48Z

src/tools/cargotest/main.rs

+                                          sha: "378da8f7d78df6e3ff0b234063de50619b16648e",
+                                          lock: None,
+                                      }
+									  Test {


Ugh, how embarrassing... Looks like circumventing my editor's insistence on 80-char lines also impeded its automatically fixing those. My apologies.

alexcrichton · 2016-10-31T20:41:55Z

@bors: r+

bors · 2016-10-31T20:41:56Z

📌 Commit 7d775e1 has been approved by alexcrichton

bors · 2016-10-31T22:26:16Z

⌛ Testing commit 7d775e1 with merge 5a54b72...

bors · 2016-10-31T23:29:02Z

💔 Test failed - auto-linux-64-cargotest

sanxiyn · 2016-11-07T05:19:55Z

src/tools/cargotest/main.rs

+                                          repo: "https://github.com/jkcclemens/bins",
+                                          sha: "378da8f7d78df6e3ff0b234063de50619b16648e",
+                                          lock: None,
+                                      }


Comma is missing here.

edunham · 2016-11-07T18:28:57Z

Sorry, I ought to have linted locally.

Fixed missing comma and rebased onto current master branch.

sanxiyn · 2016-11-07T20:46:35Z

@bors r+

bors · 2016-11-07T20:46:36Z

📌 Commit 1e951ec has been approved by sanxiyn

bors · 2016-11-07T23:04:21Z

⌛ Testing commit 1e951ec with merge d70463d...

bors · 2016-11-07T23:14:35Z

💔 Test failed - auto-linux-cross-opt

sanxiyn · 2016-11-08T02:38:13Z

@bors retry

crates.io outage.

bors · 2016-11-08T14:44:50Z

⌛ Testing commit 1e951ec with merge fb54b2f...

bors · 2016-11-08T16:02:37Z

💔 Test failed - auto-win-msvc-64-cargotest

sanxiyn · 2016-11-09T06:26:46Z

ripgrep failed two tests (symlink_follow, symlink_nofollow) on Windows.

alexcrichton · 2016-11-10T21:04:55Z

cc @BurntSushi do you know of any tricks needed to get the ripgrep test suite passing on Windows? If it's too hard for the bots then we can perhaps just exclude the suite for now and add the other repos.

BurntSushi · 2016-11-10T21:19:19Z

@alexcrichton Oh interesting! Those tests pass on AppVeyor. However, there is at least one other test on Windows dealing with symlinks that I explicitly skip on Windows because it fails on AppVeyor for the same reason (permission error) symlink_follow and symlink_nofollow are failing on buildbot. The difference between the tests is that regression_137 uses a symlink to a file where as symlink_nofollow and symlink_follow use symlinks to directories. So directories work on AppVeyor but not files. Weird.

I don't think I did any tricks though. I'd be OK skipping them in ripgrep proper, because symlinks on Windows are pretty janky anyway. Other ideas?

alexcrichton · 2016-11-10T22:28:10Z

I do recall there's some Windows permission to allow users to create symlinks, so maybe appveyor has that enabled by default? (our buildbots don't).

But yeah if you want to skip these in the ripgrep test suite we could update to include that!

For some reason, these work on AppVeyor but not in other build systems. Let's just disable them. See: rust-lang/rust#37149

BurntSushi · 2016-11-11T11:45:57Z

OK, I disabled the tests, which should take effect in the next release.

alexcrichton · 2016-11-11T15:13:59Z

Awesome, thanks @BurntSushi! @edunham want to update git git repo for ripgrep and we can retry?

bors · 2016-12-29T19:34:04Z

💔 Test failed - status-travis

alexcrichton · 2016-12-29T19:38:05Z

@bors: retry * #38618

…

On Thu, Dec 29, 2016 at 11:34 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/187525618> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#37149 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95GU4AWrg12V6lT6bJI8WZkh0ypgeks5rNAswgaJpZM4KWMBB> .

bors · 2016-12-29T22:11:09Z

⌛ Testing commit a0f3c93 with merge 9c145c2...

bors · 2016-12-29T22:19:41Z

💔 Test failed - status-appveyor

alexcrichton · 2016-12-29T23:39:43Z

@bors: retry * network error

…

On Thu, Dec 29, 2016 at 2:19 PM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang/rust/build/1.0.1313> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#37149 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95JfHa1bygutKgHWw3lQjQiWiIh3Xks5rNDH_gaJpZM4KWMBB> .

@brson

Add some more repos to cargotest From suggestions at https://users.rust-lang.org/t/what-stable-rust-applications-do-you-use-frequently/7618 This adds some applications which use stable Rust and come with their own lockfiles in their respective trees. ripgrep, xsv, and bins have 33 unique dependencies between them. I alphabetized the list by project name because that seems tidier. r? @brson

bors · 2016-12-30T03:51:28Z

⌛ Testing commit a0f3c93 with merge 1ac816c...

alexcrichton · 2016-12-30T04:46:25Z

@bors: retry

bors · 2016-12-30T05:04:59Z

⌛ Testing commit a0f3c93 with merge 738e016...

alexcrichton · 2016-12-30T05:05:21Z

@bors: retry

bors · 2016-12-30T05:50:35Z

⌛ Testing commit a0f3c93 with merge b8af359...

alexcrichton · 2016-12-30T05:58:29Z

@bors: retry

bors · 2016-12-30T06:49:43Z

⌛ Testing commit a0f3c93 with merge 42d4de0...

bors · 2016-12-30T06:54:43Z

💔 Test failed - status-travis

Rollup of 25 pull requests - Successful merges: #37149, #38491, #38517, #38559, #38587, #38609, #38611, #38622, #38628, #38630, #38631, #38632, #38635, #38647, #38649, #38655, #38659, #38660, #38662, #38665, #38671, #38674, #38676, #38693, #38695 - Failed merges: #38657, #38680

This was intended to land in rust-lang#37149 but I ended up backing it out to land the rollup (rust-lang#38697) last night as I was itching to do so. This morning though xsv has been fixed now (BurntSushi/xsv#53) so we should be able to add it!

cargotest: Add xsv to tested crates This was intended to land in #37149 but I ended up backing it out to land the rollup (#38697) last night as I was itching to do so. This morning though xsv has been fixed now (BurntSushi/xsv#53) so we should be able to add it!

rust-highfive assigned brson Oct 13, 2016

jonas-schievink reviewed Oct 13, 2016

View reviewed changes

edunham force-pushed the more-cargotest branch from 4f71566 to 7d775e1 Compare October 13, 2016 18:48

sanxiyn reviewed Nov 7, 2016

View reviewed changes

edunham force-pushed the more-cargotest branch from 7d775e1 to 1e951ec Compare November 7, 2016 18:28

BurntSushi added a commit to BurntSushi/ripgrep that referenced this pull request Nov 11, 2016

Disable symlink tests on Windows.

4b18f82

For some reason, these work on AppVeyor but not in other build systems. Let's just disable them. See: rust-lang/rust#37149

alexcrichton mentioned this pull request Dec 30, 2016

Rollup of 25 pull requests #38697

Merged

bors merged commit a0f3c93 into rust-lang:master Dec 30, 2016

alexcrichton mentioned this pull request Dec 30, 2016

cargotest: Add xsv to tested crates #38709

Merged

Add some more repos to cargotest #37149

Add some more repos to cargotest #37149

Conversation

edunham commented Oct 13, 2016

rust-highfive commented Oct 13, 2016

alexcrichton commented Oct 13, 2016

bors commented Oct 13, 2016

jonas-schievink Oct 13, 2016

Choose a reason for hiding this comment

edunham Oct 13, 2016

Choose a reason for hiding this comment

alexcrichton commented Oct 31, 2016

bors commented Oct 31, 2016

bors commented Oct 31, 2016

bors commented Oct 31, 2016

sanxiyn Nov 7, 2016

Choose a reason for hiding this comment

edunham commented Nov 7, 2016

sanxiyn commented Nov 7, 2016

bors commented Nov 7, 2016

bors commented Nov 7, 2016

bors commented Nov 7, 2016

sanxiyn commented Nov 8, 2016

bors commented Nov 8, 2016

bors commented Nov 8, 2016

sanxiyn commented Nov 9, 2016

alexcrichton commented Nov 10, 2016

BurntSushi commented Nov 10, 2016 • edited Loading

alexcrichton commented Nov 10, 2016

BurntSushi commented Nov 11, 2016

alexcrichton commented Nov 11, 2016

bors commented Dec 29, 2016

alexcrichton commented Dec 29, 2016 via email

bors commented Dec 29, 2016

bors commented Dec 29, 2016

alexcrichton commented Dec 29, 2016 via email

bors commented Dec 30, 2016

alexcrichton commented Dec 30, 2016

bors commented Dec 30, 2016

alexcrichton commented Dec 30, 2016

bors commented Dec 30, 2016

alexcrichton commented Dec 30, 2016

bors commented Dec 30, 2016

bors commented Dec 30, 2016

BurntSushi commented Nov 10, 2016 •

edited

Loading