Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment in Vec::dedup_by #37215

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Conversation

flodiebold
Copy link
Member

It's a tiny thing, but I came across this comment which previously was in dedup and wasn't updated when dedup_by was introduced.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sfackler
Copy link
Member

@bors r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Oct 16, 2016

📌 Commit 187ddf3 has been approved by sfackler

@bors
Copy link
Contributor

bors commented Oct 16, 2016

⌛ Testing commit 187ddf3 with merge 07fd313...

@bors
Copy link
Contributor

bors commented Oct 16, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Sun, Oct 16, 2016 at 9:51 AM, bors notifications@github.com wrote:

💔 Test failed - auto-mac-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-mac-64-opt-rustbuild/builds/2736


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#37215 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95DH868N8J8QQO7NQpNKxM9VFNZ24ks5q0lYcgaJpZM4KX-AI
.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 17, 2016
Update comment in Vec::dedup_by

It's a tiny thing, but I came across this comment which previously was in `dedup` and wasn't updated when `dedup_by` was introduced.
bors added a commit that referenced this pull request Oct 18, 2016
Rollup of 6 pull requests

- Successful merges: #37172, #37177, #37189, #37194, #37200, #37215
- Failed merges:
@bors bors merged commit 187ddf3 into rust-lang:master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants