Fix some mistakes in HRTB docs #37255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example code for higher-ranked trait bounds on closures had an unnecessary `mut` which was confusing, and the text referred to an mutable reference which does not exist in the code (and isn't needed). Removed the `mut`s and fixed the text to better describe the actual error for the failing example.
|
@bors: delegate=kmcallister I think this looks good. What do you think, @kmcallister ? |
|
✌️ @kmcallister can now approve this pull request |
|
@bors: r+ rollup |
|
📌 Commit f89ba5d has been approved by |
|
⌛ Testing commit f89ba5d with merge 6c17a05... |
|
💔 Test failed - auto-mac-64-opt-rustbuild |
|
@bors: retry |
|
⌛ Testing commit f89ba5d with merge bacff0a... |
|
💔 Test failed - auto-mac-64-opt-rustbuild |
|
@bors: retry |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Nov 4, 2016
Fix some mistakes in HRTB docs The example code for higher-ranked trait bounds on closures had an unnecessary `mut` which was confusing, and the text referred to an mutable reference which does not exist in the code (and isn't needed). Removed the `mut`s and fixed the text to better describe the actual error for the failing example. Thanks to csd_ on IRC for pointing out these problems! r? @steveklabnik
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 4, 2016
Fix some mistakes in HRTB docs The example code for higher-ranked trait bounds on closures had an unnecessary `mut` which was confusing, and the text referred to an mutable reference which does not exist in the code (and isn't needed). Removed the `mut`s and fixed the text to better describe the actual error for the failing example. Thanks to csd_ on IRC for pointing out these problems! r? @steveklabnik
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Nov 5, 2016
Fix some mistakes in HRTB docs The example code for higher-ranked trait bounds on closures had an unnecessary `mut` which was confusing, and the text referred to an mutable reference which does not exist in the code (and isn't needed). Removed the `mut`s and fixed the text to better describe the actual error for the failing example. Thanks to csd_ on IRC for pointing out these problems! r? @steveklabnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example code for higher-ranked trait bounds on closures had an unnecessary
mutwhich was confusing, and the text referred to an mutable reference which does not exist in the code (and isn't needed). Removed themuts and fixed the text to better describe the actual error for the failing example.Thanks to csd_ on IRC for pointing out these problems!
r? @steveklabnik