Add a module to getopts for verbose option group declaration (and use it in rustc) #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll push a patch in a few minutes which renames the module to |
|
About to push another patch with an extra test, rebased off the latest incoming... |
|
Looks good overall. I'll merge if you fix the few nits that I pointed out. Thanks! |
This is built on top of the existing functionality, but adds a `groups` module which defines functions allowing the user to specify whole short/long/description groups at once and provides a usage message.
|
(Running the tests now...) |
catamorphism
added a commit
that referenced
this pull request
Oct 17, 2012
Add a module to getopts for verbose option group declaration (and use it in rustc)
|
Thanks! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 31, 2024
fix: Goto implementation to impls inside blocks Fixes rust-lang#3739
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Jul 14, 2024
Implement support for multiple TLS destructors on macOS I want to get rid of [this `#[cfg]` block](https://github.com/rust-lang/rust/blob/98dcbae5c9ac615d5acfbf42d42b19a77cb9ec11/library/std/src/thread/mod.rs#L195-L211) in `std`, but it is currently required for miri, as it does not support multiple macOS TLS destructors. This is not true for the platform itself, however, as can be observed in the [implementation](https://github.com/apple-oss-distributions/dyld/blob/d552c40cd1de105f0ec95008e0e0c0972de43456/dyld/DyldRuntimeState.cpp#L2239).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of existing functionality, but adds a module which allows the user to specify whole short/long/description groups at once and provides a usage message.
Tests pass on incoming with
CFG_DISABLE_VALGRIND=1 make check.