-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn unused type aliases #37631
Warn unused type aliases #37631
Conversation
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
r? @eddyb |
What's the motivation between the changes to how path resolutions are stored? |
The motivation is to read partial resolution after it is overwritten by full resolution in It can be achieved by simply keeping a copy of |
@sanxiyn Ah this is completely unnecessary on my branch, which has a separate HIR node for the original resolution (i.e. the |
Sure. It would be much better if I can get the original resolution directly from HIR node without maintaining the side table. Thanks. |
Nice fix. |
Remove unused type aliases Found by rust-lang/rust#37631 and necessary to land because of cargotest.
☔ The latest upstream changes (presumably #37732) made this pull request unmergeable. Please resolve the merge conflicts. |
41e0b5a
to
6c3af17
Compare
6c3af17
to
2f858e7
Compare
☔ The latest upstream changes (presumably #37676) made this pull request unmergeable. Please resolve the merge conflicts. |
Sorry for the delay but this should be straight-forward now. |
Should this be closed? |
I will close this when the reimplementation lands. |
The interesting part (type aliases used by UFCS) is already tested by
issue-23808.rs
. But it only tests used type aliases are not warned, so I added a simple test to test unused type aliases are warned.Fix #37455.