UTF-8 validation: Compute block end upfront #37926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the conditional used for ensuring that the whole word loop is only used if there are at least two whole words left to read. This makes the function slightly smaller and simpler, a 0-5% reduction in runtime for various test cases.
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
bluss
changed the title
|
This seems fine to me, though the changes seem minimal enough that it's a bit weird that LLVM can't do as well with the original implementation. |
|
ping @sfackler , are you fine enough with this to merge it? |
|
@bors r+ |
|
@bors r=sfackler |
|
📌 Commit 0dffc1e has been approved by |
|
Thank you :) I do think the simplification of the conditional is a needed cleanup. |
|
⌛ Testing commit 0dffc1e with merge 45fc03d... |
|
💔 Test failed - status-travis |
|
… On Wed, Jan 11, 2017 at 12:11 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/191055215>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#37926 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95B7JimRQORVP4-ramndOTlDerAKsks5rRTeKgaJpZM4K4xpP>
.
|
|
⌛ Testing commit 0dffc1e with merge 8548cc3... |
|
💔 Test failed - status-travis |
|
… On Wed, Jan 11, 2017 at 5:00 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/191160347>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#37926 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95HpYJNrMRHPtJ6XpzMwWGvanX1HXks5rRXszgaJpZM4K4xpP>
.
|
|
⌛ Testing commit 0dffc1e with merge 408c2f7... |
bors
added a commit
that referenced
this pull request
Jan 12, 2017
UTF-8 validation: Compute block end upfront Simplify the conditional used for ensuring that the whole word loop is only used if there are at least two whole words left to read. This makes the function slightly smaller and simpler, a 0-5% reduction in runtime for various test cases.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the conditional used for ensuring that the whole word loop is
only used if there are at least two whole words left to read.
This makes the function slightly smaller and simpler, a 0-5% reduction
in runtime for various test cases.