Simplify notes on testing and concurrency #38013
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
☔ The latest upstream changes (presumably #38148) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Hey @wezm , I'm so sorry that my review here has slipped. Catching up on all of them now. I'm in favor of this patch, but it seems to be out of date now. That's my fault; can you rebase it, please? I'm happy to help with that if you need any. |
wezm
force-pushed
the
simplify-test-notes
branch
from
9136dfb
to
517fce0
Compare
|
No worries @steveklabnik PR updated. |
|
Travis failure shouldn't be a problem. Thanks! @bors: r+ rollup |
|
📌 Commit 517fce0 has been approved by |
…abnik Simplify notes on testing and concurrency The start of the notes on tests running concurrently, added in rust-lang#37766 read a little awkwardly. This PR fixes that and simplifies the wording a bit. r? @steveklabnik
The start of the notes on tests running concurrently, added in #37766 read a little awkwardly. This PR fixes that and simplifies the wording a bit.
r? @steveklabnik