macros: allow a `path` fragment to be parsed as a type parameter bound #38279

KalitaAlexey · 2016-12-10T07:59:09Z

Allow a path fragment to be parsed as a type parameter bound.
Fixes #8521.

rust-highfive · 2016-12-10T07:59:23Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

KalitaAlexey · 2016-12-10T13:51:41Z

It has failed. Is it me?

bluss · 2016-12-10T15:08:03Z

It looks like the failure is not related to the PR, it ran all tests successfully.

Unfortunately all PRs fail on travis right now: https://travis-ci.org/rust-lang/rust/builds

KalitaAlexey · 2016-12-10T17:40:11Z

Hi @bluss,

Thank you for the explanation.

Should I just wait or what?

Regards,
Alexey

bluss · 2016-12-10T18:13:37Z

Wait or maybe seek out and ask someone if they want to review your PR. It's not my area, so I will not review it.

brson · 2016-12-11T23:10:09Z

@KalitaAlexey @nrc will review soon, but has been traveling lately.

KalitaAlexey · 2016-12-12T04:17:43Z

Hi @brson,

I'll wait. It's not problem.

Regards,
Alexey

jseyfried · 2016-12-12T04:20:26Z

src/libsyntax/parse/parser.rs

+                        }
+                        _ => break,
+                    }
+                }
                token::ModSep | token::Ident(..) => {


Instead of adding the token::Interpolated(ref nt) => { ... } arm, I believe you could just change this pattern to

_ if self.token.is_path_start() || self.token.is_keyword(keywords::For) => { ... }

I'll examine your suggestion.

jseyfried · 2016-12-12T04:20:46Z

src/test/ui/macros/macro_path_as_generic_bound.rs

+trait Foo {}
+
+macro_rules! foo(($t:path) => {
+  impl<T: $t> Foo for T {}


nit: indent 4 spaces

I'll fix it.

jseyfried · 2016-12-12T04:21:17Z

src/test/ui/macros/macro_path_as_generic_bound.rs

+foo!(m::m2::A);
+
+fn main() {}
+


nit: trailing newline (in both tests)

I'll fix it.

jseyfried · 2016-12-12T04:25:50Z

cc @petrochenkov

KalitaAlexey · 2016-12-14T06:24:49Z

Hi @jseyfried,
My commit somehow breaks src/test/run-pass/issue-28950.rs
I don't understand why.

Could you look at it?

Thanks

jseyfried · 2016-12-14T07:25:12Z

What commit breaks run-pass/issue-28950.rs? The current PR or my suggestion?
In what way does it break? What is the error message?

KalitaAlexey · 2016-12-14T08:22:31Z

@jseyfried,

I don't know why, but my PR enough to break the test.
I checked it before and it worked.
It should run and pass, but it crashes with segfault.

Thanks

jseyfried · 2016-12-14T08:30:47Z

That sounds unrelated to this PR, but I don't have enough information to help debug further. Could you provide hash of the commit that breaks the test, the exact output when it crashes, and ideally a backtrace?

KalitaAlexey · 2016-12-14T09:02:10Z

Hm. Actually my installed rustc also creates an executable failing with segfault.

Mark-Simulacrum · 2016-12-14T21:03:29Z

@KalitaAlexey Can you attempt to provide a backtrace? Either way, please file a new issue (since this seems unrelated to this PR), with your OS distro and version, as well as rustc version so we can try to diagnose. I just verified locally, and it doesn't segfault for me.

Mark-Simulacrum · 2016-12-14T21:36:16Z

Never mind. I had forgotten to run the produced executable, will post the new issue myself once I get a backtrace if you don't get to it first.

Mark-Simulacrum · 2016-12-14T21:44:36Z

Oh. That tests currently doesn't support non-optimized codegen (no -O); @KalitaAlexey are you running without that for some reason?

KalitaAlexey · 2016-12-15T09:40:45Z

Hi @Mark-Simulacrum,

I just ran ./x.py test.

KalitaAlexey · 2016-12-16T08:33:23Z

Hi @jseyfried,

I applied your suggestions.

Thanks.

jseyfried

r=me modulo nit

jseyfried · 2016-12-16T08:36:21Z

src/test/run-pass/issue-8521.rs

+foo2!(B<C>);
+
+fn main() {}
+


nit: trailing newline

jseyfried · 2016-12-16T08:39:37Z

src/test/run-pass/issue-8521.rs

@@ -0,0 +1,35 @@
+// Copyright 2014 The Rust Project Developers. See the COPYRIGHT


nit: 2016, not 2014

I'll fix it.

KalitaAlexey · 2016-12-16T10:28:12Z

@jseyfried, I've done it.

jseyfried · 2016-12-16T10:32:06Z

@KalitaAlexey Thanks!
One last thing -- could you squash the commits so that this PR is a single commit?

KalitaAlexey · 2016-12-16T10:54:43Z

@jseyfried, how should I do it? I don't know right way.

jseyfried · 2016-12-16T11:02:45Z

cd rust
git checkout master
git checkout -b tmp
git merge issue-8521 --no-ff
git reset master
git add src
git commit -m "allow path fragments to be parsed as type parameter bounds"
git branch -D issue-8521
git branch -m issue-8521
git push origin issue-8521 --force

…xpansion

KalitaAlexey · 2016-12-16T11:18:26Z

I've done what you had suggested me. Thank you.

jseyfried · 2016-12-16T11:22:09Z

@bors r+

bors · 2016-12-16T11:22:11Z

📌 Commit 12a6cf1 has been approved by jseyfried

bors · 2016-12-16T11:34:19Z

⌛ Testing commit 12a6cf1 with merge 9652757...

bors · 2016-12-16T11:36:28Z

💔 Test failed - auto-win-msvc-64-opt

jseyfried · 2016-12-16T11:41:14Z

@bors retry clean

bors · 2016-12-16T11:43:46Z

⌛ Testing commit 12a6cf1 with merge bf9e5a8...

bors · 2016-12-16T11:46:35Z

💔 Test failed - auto-win-msvc-64-opt

alexcrichton · 2016-12-16T20:44:32Z

@bors: retry

bors · 2016-12-17T21:49:52Z

⌛ Testing commit 12a6cf1 with merge ec8bb45...

macros: allow a `path` fragment to be parsed as a type parameter bound Allow a `path` fragment to be parsed as a type parameter bound. Fixes #8521.

bors · 2016-12-18T01:07:26Z

rust-highfive assigned nrc Dec 10, 2016

jseyfried reviewed Dec 12, 2016

View reviewed changes

jseyfried assigned jseyfried and unassigned nrc Dec 12, 2016

jseyfried changed the title ~~fixes #8521~~ macros: allow a path fragment to be parsed as a type parameter bound Dec 12, 2016

jseyfried reviewed Dec 16, 2016

View reviewed changes

Allow path fragments to be parsed as type parameter bounds in macro e…

12a6cf1

…xpansion

KalitaAlexey force-pushed the issue-8521 branch from 22c2089 to 12a6cf1 Compare December 16, 2016 11:18

bors added a commit that referenced this pull request Dec 17, 2016

Auto merge of #38279 - KalitaAlexey:issue-8521, r=jseyfried

ec8bb45

macros: allow a `path` fragment to be parsed as a type parameter bound Allow a `path` fragment to be parsed as a type parameter bound. Fixes #8521.

bors merged commit 12a6cf1 into rust-lang:master Dec 18, 2016

KalitaAlexey deleted the issue-8521 branch December 18, 2016 07:22

abonander mentioned this pull request Dec 21, 2016

Generic/where clause bounds generated by a macro fail to parse even when syntactically correct #38461

Closed

		@@ -0,0 +1,35 @@
		// Copyright 2014 The Rust Project Developers. See the COPYRIGHT

		foo!(m::m2::A);

		fn main() {}

		foo2!(B<C>);

		fn main() {}

macros: allow a path fragment to be parsed as a type parameter bound #38279

macros: allow a path fragment to be parsed as a type parameter bound #38279

Conversation

KalitaAlexey commented Dec 10, 2016 • edited by jseyfried Loading

rust-highfive commented Dec 10, 2016

KalitaAlexey commented Dec 10, 2016

bluss commented Dec 10, 2016

KalitaAlexey commented Dec 10, 2016

bluss commented Dec 10, 2016 • edited Loading

brson commented Dec 11, 2016

KalitaAlexey commented Dec 12, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jseyfried commented Dec 12, 2016

KalitaAlexey commented Dec 14, 2016

jseyfried commented Dec 14, 2016

KalitaAlexey commented Dec 14, 2016

jseyfried commented Dec 14, 2016

KalitaAlexey commented Dec 14, 2016

Mark-Simulacrum commented Dec 14, 2016

Mark-Simulacrum commented Dec 14, 2016

Mark-Simulacrum commented Dec 14, 2016

KalitaAlexey commented Dec 15, 2016

KalitaAlexey commented Dec 16, 2016

jseyfried left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KalitaAlexey commented Dec 16, 2016

jseyfried commented Dec 16, 2016

KalitaAlexey commented Dec 16, 2016

jseyfried commented Dec 16, 2016 • edited Loading

KalitaAlexey commented Dec 16, 2016

jseyfried commented Dec 16, 2016

bors commented Dec 16, 2016

bors commented Dec 16, 2016

bors commented Dec 16, 2016

jseyfried commented Dec 16, 2016

bors commented Dec 16, 2016

bors commented Dec 16, 2016

alexcrichton commented Dec 16, 2016

bors commented Dec 17, 2016

bors commented Dec 18, 2016

macros: allow a `path` fragment to be parsed as a type parameter bound #38279

macros: allow a `path` fragment to be parsed as a type parameter bound #38279

KalitaAlexey commented Dec 10, 2016 •

edited by jseyfried

Loading

bluss commented Dec 10, 2016 •

edited

Loading

jseyfried commented Dec 16, 2016 •

edited

Loading