rustdoc: Fix invalid HTML in stability notices #38329
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
It's the |
|
Good catch! Some CSS changes are a bit strange for me, do you have a live versions of this change by any chance? |
`em` tags cannot contain `p` tags so just use a `div` instead.
ollie27
force-pushed
the
rustdoc_stab_em_div
branch
from
41735fa
to
e395fd1
Compare
|
I've just force pushed a fix for a small layout issue I noticed. https://ollie27.github.io/rust_doc_test/std/index.html has this change applied. The only real difference that I can see is that the collapse button now appear for methods that are both unstable and depreciated: before after. |
|
LGTM. Travis failure is irrelevant. @bors: r+ Thanks! |
|
📌 Commit e395fd1 has been approved by |
|
⌛ Testing commit e395fd1 with merge 8d1023b... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry
…On Thu, Dec 22, 2016 at 2:28 PM, bors ***@***.***> wrote:
💔 Test failed - auto-mac-32-opt
<https://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/11426>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38329 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95KFZja6U56G0YHm4BSKYV8GLjI7hks5rKvmMgaJpZM4LLGkL>
.
|
|
⌛ Testing commit e395fd1 with merge bb54588... |
|
@bors: retry |
|
⌛ Testing commit e395fd1 with merge eb34cb7... |
|
💔 Test failed - status-appveyor |
|
⌛ Testing commit e395fd1 with merge fcc43fa... |
|
💔 Test failed - status-travis |
|
@bors: retry
er... a stray sighup killed something?
…On Mon, Dec 26, 2016 at 6:18 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/186882942>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38329 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95K_qTnp1A-MNi92DfGuxoxfS_VBjks5rMHVbgaJpZM4LLGkL>
.
|
|
⌛ Testing commit e395fd1 with merge e63300a... |
|
💔 Test failed - status-travis |
|
@bors: retry
* network error
…On Mon, Dec 26, 2016 at 9:07 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/186900148>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38329 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95M5ucB0Yu6IWqF41gBFId0HdR7e6ks5rMJ0HgaJpZM4LLGkL>
.
|
|
⌛ Testing commit e395fd1 with merge 6e34629... |
|
💔 Test failed - status-appveyor |
|
Hmm, not sure if this failure is spurious or not. |
|
… On Tue, Dec 27, 2016 at 6:31 AM, Steve Klabnik ***@***.***> wrote:
Hmm, not sure if this failure is spurious or not.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38329 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95NEchbxSd3PW7QJSiVhYGipi1l-Kks5rMSFXgaJpZM4LLGkL>
.
|
rustdoc: Fix invalid HTML in stability notices `em` tags cannot contain `p` tags so use `div`s instead of `em`s as the Markdown will create `p` tags.
|
☀️ Test successful - status-appveyor, status-travis |
…frewsxcv rustdoc: Fix broken CSS for trait items The `stab` class shouldn't have any effect here so can be removed as currently it adds an outline. This was accidentally caused by rust-lang#38329. [before](https://doc.rust-lang.org/nightly/std/iter/trait.ExactSizeIterator.html) [after](https://ollie27.github.io/rust_doc_test/std/iter/trait.ExactSizeIterator.html)
emtags cannot containptags so usedivs instead ofems as the Markdown will createptags.