-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run rustfmt on astconv.rs file #38567
Conversation
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
//! So this function is used when we're dealing with a sum type to | ||
//! convert the LHS. It only accepts a type that refers to a trait | ||
//! name, and reports an error otherwise. | ||
//! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I guess the trailing blank //!
is a feature, not a bug, of rustfmt
(since IIUC it refuses to revise the layout of comments in terms of line breaks ... though I had thought @nrc had said something about it being willing to remove some blank lines in certain cases...)
@bors r+ rollup |
📌 Commit f8db005 has been approved by |
☔ The latest upstream changes (presumably #38154) made this pull request unmergeable. Please resolve the merge conflicts. |
@pnkfelix merge conflicts resolved. Please approve again. |
@bors r+ rollup |
📌 Commit a6d2929 has been approved by |
☔ The latest upstream changes (presumably #38449) made this pull request unmergeable. Please resolve the merge conflicts. |
gosh!! @pnkfelix Please rollup again. |
☔ The latest upstream changes (presumably #39110) made this pull request unmergeable. Please resolve the merge conflicts. |
PR #38842 has exposed that we were missing the src/test/compile-fail-fulldeps directory in the search for feature gate tests. Because the detection didn't work despite the effort to name the test appropriately and add a correct "// gate-test-proc_macro" comment, proc_macro was added to the whitelist. We fix this little weakness in the feature gate tidy check and add the src/test/compile-fail-fulldeps directory to the checked directories.
Closing due to inactivity, but feel free to resubmit with a rebase! |
No description provided.