Making code style consistent for src/rustllvm (#38688) #38701
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Whitespace-ignoring diff: https://github.com/rust-lang/rust/pull/38701/files?w=1 |
| Expected<StringRef> name_or_err = child->getName(); | ||
| if (!name_or_err) { | ||
| // rustc_llvm currently doesn't use this error string, but it might be | ||
| // useful |
There was a problem hiding this comment.
I'm a bit disappointed clang-format didn't re-wrap this. Mind fixing this up by hand?
|
Looks good to me, thanks a lot! Will you also be tackling other bullet points from #38688, and if so, will it be in this PR or in a future PR? |
karpinski
force-pushed
the
rustllvm-style
branch
from
4345ace
to
72ebc02
Compare
|
@rkruppe I figured I would give someone else a chance to take a stab at the rest of them :) |
|
@bors r+ Thanks @karpinski ! |
|
📌 Commit 72ebc02 has been approved by |
|
⌛ Testing commit 72ebc02 with merge 6dcf51a... |
|
☀️ Test successful - status-appveyor, status-travis |
Part of #38688
r? @brson