-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sign formatting for numeric types in docs #38704
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
📌 Commit 5e836ae has been approved by |
Tidy issue:
@bors: r- |
//! * `-` - Currently not used | ||
//! (`+` or `-`) should always be printed. Positive signs are never | ||
//! printed by default. This behavior is controlled by using the | ||
//! [pad_integral](struct.Formatter.html#method.pad_integral) method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Url shouldn't be formatted this way. First the [pad_integrad]
then below [pad_integral]: struct.Formatter.html#method.pad_integral
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And url should be: ../std/fmt/struct.Formatter.html#method.pad_integral
.
Sign formatting is no longer controlled by a `Signed` trait. Instead, `pad_integral` is used and implemented for numeric types by default. Fixes #38677
@GuillaumeGomez I have fixed the formatting for the link. The link as is works on my local build of
|
Tests passed, you fixed the issue, all good! Thanks for your work! PS: my url missed a "..", but it doesn't matter if yours works just fine. @bors: r+ rollup |
📌 Commit f05f9b1 has been approved by |
Fixes #38677
Sign formatting is no longer controlled by a
Signed
trait. Instead,pad_integral
is used and implemented for numeric types by default.