Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Start uploading artifacts on commits #38748

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

alexcrichton
Copy link
Member

This commit starts adding the infrastructure for uploading release artifacts
from AppVeyor/Travis on each commit. The idea is that eventually we'll upload a
full release to AppVeyor/Travis in accordance with plans outlined earlier.

Right now this configures Travis/Appveyor to upload all tarballs in the dist
directory, and various images are updated to actually produce tarballs in these
directories. These are nowhere near ready to be actual release artifacts, but
this should allow us to play around with it and test it out. Once this commit
lands we should start seeing artifacts uploaded on each commit.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@@ -123,6 +127,32 @@ branches:
only:
- auto

after_test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be before_deploy? (like Travis)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird I thought this didn't exist... I'll change it!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait right we can't do that because otherwise the artifacts listing on AppVeyor fails. Those artifacts have to be in place before the deploy (and before_deploy) step starts I believe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have seen that too but you can Push-AppveyorArtifact the artifacts in the before_deploy phase. You still have to declare them in appveyor.yml though but a glob works.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned about this after_test stuff running on all AppVeyor build jobs rathern than only on those that are going to be "deployed".

@bors
Copy link
Contributor

bors commented Jan 5, 2017

☔ The latest upstream changes (presumably #38731) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member Author

Ok I've rebased and updated how AppVeyor uploads.

r? @brson

before_deploy:
- mkdir -p deploy/$TRAVIS_COMMIT
- >
if [ "$TRAVIS_OS_NAME" == "osx" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: single square brackets should use =. Otherwise use [[ to make it clear bash is required.

@brson
Copy link
Contributor

brson commented Jan 10, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Jan 10, 2017

📌 Commit 4c94686 has been approved by brson

@bors
Copy link
Contributor

bors commented Jan 10, 2017

⌛ Testing commit 4c94686 with merge 4dea79d...

@bors
Copy link
Contributor

bors commented Jan 10, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Jan 10, 2017

📌 Commit be31abb has been approved by brson

@bors
Copy link
Contributor

bors commented Jan 10, 2017

⌛ Testing commit be31abb with merge c938a03...

@bors
Copy link
Contributor

bors commented Jan 10, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Jan 10, 2017

📌 Commit 7ff6b67 has been approved by brson

@bors
Copy link
Contributor

bors commented Jan 10, 2017

⌛ Testing commit 7ff6b67 with merge 9d2a338...

@bors
Copy link
Contributor

bors commented Jan 10, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Jan 10, 2017

📌 Commit 7cf8dee has been approved by brson

@bors
Copy link
Contributor

bors commented Jan 10, 2017

⌛ Testing commit 7cf8dee with merge 236a18a...

@bors
Copy link
Contributor

bors commented Jan 10, 2017

📌 Commit 5e40c5b has been approved by brson

@bors
Copy link
Contributor

bors commented Jan 11, 2017

⌛ Testing commit 5e40c5b with merge 8d43b96...

@bors
Copy link
Contributor

bors commented Jan 11, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

alexcrichton commented Jan 11, 2017 via email

@bors
Copy link
Contributor

bors commented Jan 11, 2017

⌛ Testing commit 5e40c5b with merge ac67e1f...

@bors
Copy link
Contributor

bors commented Jan 11, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Jan 11, 2017

📌 Commit 5d52402 has been approved by brson

@bors
Copy link
Contributor

bors commented Jan 11, 2017

⌛ Testing commit 5d52402 with merge efeca8f...

@bors
Copy link
Contributor

bors commented Jan 12, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member Author

alexcrichton commented Jan 12, 2017 via email

@bors
Copy link
Contributor

bors commented Jan 12, 2017

⌛ Testing commit 5d52402 with merge 0b93364...

bors added a commit that referenced this pull request Jan 12, 2017
travis: Start uploading artifacts on commits

This commit starts adding the infrastructure for uploading release artifacts
from AppVeyor/Travis on each commit. The idea is that eventually we'll upload a
full release to AppVeyor/Travis in accordance with plans [outlined earlier].

Right now this configures Travis/Appveyor to upload all tarballs in the `dist`
directory, and various images are updated to actually produce tarballs in these
directories. These are nowhere near ready to be actual release artifacts, but
this should allow us to play around with it and test it out. Once this commit
lands we should start seeing artifacts uploaded on each commit.

[outlined earlier]: https://internals.rust-lang.org/t/rust-ci-release-infrastructure-changes/4489
@bors
Copy link
Contributor

bors commented Jan 12, 2017

💔 Test failed - status-travis

This commit starts adding the infrastructure for uploading release artifacts
from AppVeyor/Travis on each commit. The idea is that eventually we'll upload a
full release to AppVeyor/Travis in accordance with plans [outlined earlier].

Right now this configures Travis/Appveyor to upload all tarballs in the `dist`
directory, and various images are updated to actually produce tarballs in these
directories. These are nowhere near ready to be actual release artifacts, but
this should allow us to play around with it and test it out. Once this commit
lands we should start seeing artifacts uploaded on each commit.

[outlined earlier]: https://internals.rust-lang.org/t/rust-ci-release-infrastructure-changes/4489
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Jan 12, 2017

📌 Commit 3187672 has been approved by brson

@bors
Copy link
Contributor

bors commented Jan 13, 2017

⌛ Testing commit 3187672 with merge 927c55d...

bors added a commit that referenced this pull request Jan 13, 2017
travis: Start uploading artifacts on commits

This commit starts adding the infrastructure for uploading release artifacts
from AppVeyor/Travis on each commit. The idea is that eventually we'll upload a
full release to AppVeyor/Travis in accordance with plans [outlined earlier].

Right now this configures Travis/Appveyor to upload all tarballs in the `dist`
directory, and various images are updated to actually produce tarballs in these
directories. These are nowhere near ready to be actual release artifacts, but
this should allow us to play around with it and test it out. Once this commit
lands we should start seeing artifacts uploaded on each commit.

[outlined earlier]: https://internals.rust-lang.org/t/rust-ci-release-infrastructure-changes/4489
@bors
Copy link
Contributor

bors commented Jan 13, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing 927c55d to master...

@bors bors merged commit 3187672 into rust-lang:master Jan 13, 2017
@bors bors mentioned this pull request Jan 13, 2017
@alexcrichton alexcrichton deleted the upload branch January 13, 2017 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants