Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'platform-specific' section to sleep_ms to match sleep. #38761

Merged
merged 1 commit into from
Jan 21, 2017

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Jan 1, 2017

No description provided.

@retep998
Copy link
Member

retep998 commented Jan 2, 2017

There is an equivalent thing on Windows, where the sleep won't return early due to an asynchronous procedure call because it isn't an alertable sleep.

@alexcrichton
Copy link
Member

@bors: r+

Thanks @frewsxcv!

@bors
Copy link
Contributor

bors commented Jan 19, 2017

📌 Commit 20fd6cc has been approved by alexcrichton

@alexcrichton alexcrichton self-assigned this Jan 19, 2017
@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jan 19, 2017
@bors
Copy link
Contributor

bors commented Jan 19, 2017

⌛ Testing commit 20fd6cc with merge f8779b6...

bors added a commit that referenced this pull request Jan 19, 2017
Add 'platform-specific' section to `sleep_ms` to match `sleep`.

None
@bors
Copy link
Contributor

bors commented Jan 19, 2017

💥 Test timed out

@alexcrichton
Copy link
Member

@bors: retry

Presumably some bug in @bors? The builds both completed sucessfully: https://travis-ci.org/rust-lang/rust/builds/193285888 and https://ci.appveyor.com/project/rust-lang/rust/build/1.0.1606.

@bors
Copy link
Contributor

bors commented Jan 20, 2017

⌛ Testing commit 20fd6cc with merge 435118e...

@frewsxcv
Copy link
Member Author

@bors rollup

@alexcrichton
Copy link
Member

@bors: retry

  • interrupting to bump the rollup up

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 20, 2017
…=alexcrichton

Add 'platform-specific' section to `sleep_ms` to match `sleep`.

None
bors added a commit that referenced this pull request Jan 20, 2017
bors added a commit that referenced this pull request Jan 21, 2017
@bors bors merged commit 20fd6cc into rust-lang:master Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants