Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only consider value items when searching for methods, not types #39019

Merged
merged 3 commits into from
Jan 18, 2017

Conversation

nikomatsakis
Copy link
Contributor

Fixes #38919

r? @eddyb

@nikomatsakis nikomatsakis added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 12, 2017
@petrochenkov
Copy link
Contributor

Fixes #38145 as well

@eddyb
Copy link
Member

eddyb commented Jan 12, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Jan 12, 2017

📌 Commit 8848c38 has been approved by eddyb

@nikomatsakis
Copy link
Contributor Author

@bors r-

Travis...seems unhappy. I'll investigate.

@brson
Copy link
Contributor

brson commented Jan 17, 2017

@nikomatsakis Time is getting short to backport this.

@brson brson mentioned this pull request Jan 17, 2017
@nikomatsakis
Copy link
Contributor Author

@brson let's see if travis is happy, but I think it's fixed now

@nikomatsakis
Copy link
Contributor Author

So for some reason this particular example, now that it doesn't ICE, triggers an odd path where we try to cite some code from libstd:

note: candidate #1 is defined in the trait `std::iter::Iterator`
  --> src/libcore/iter/iterator.rs:34:5
   |
34 |
   |     ^^^^^^^^^^
   = help: items from traits can only be used if the trait is implemented and in scope; the following traits define an item `Item`, perhaps you need to implement one of them:
   = help: candidate #1: `std::iter::Iterator`
   = help: candidate #2: `std::iter::IntoIterator`
   = help: candidate #3: `std::iter::ZipImpl`
   = help: candidate #4: `core::slice::SliceExt`

(See the snippet for candidate #1)

I don't quite follow what's happening there, but it seems like a pre-existing bug?

@nikomatsakis
Copy link
Contributor Author

@bors r=eddyb p=1

  • Beta backport

@bors
Copy link
Contributor

bors commented Jan 18, 2017

📌 Commit d82d4b6 has been approved by eddyb

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 18, 2017
@nikomatsakis
Copy link
Contributor Author

Accepting for beta backport (tiny patch, regression).

cc @rust-lang/compiler

@bors
Copy link
Contributor

bors commented Jan 18, 2017

⌛ Testing commit d82d4b6 with merge be1daa4...

bors added a commit that referenced this pull request Jan 18, 2017
only consider value items when searching for methods, not types

Fixes #38919

r? @eddyb
@bors
Copy link
Contributor

bors commented Jan 18, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing be1daa4 to master...

@bors bors merged commit d82d4b6 into rust-lang:master Jan 18, 2017
@brson brson mentioned this pull request Jan 19, 2017
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 19, 2017
@nikomatsakis nikomatsakis deleted the issue-38919 branch April 14, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants