Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If submodule init fails, try from scratch #39055

Merged
merged 1 commit into from
Jan 15, 2017

Conversation

aidanhs
Copy link
Member

@aidanhs aidanhs commented Jan 14, 2017

See #39051

I wonder if the cause could be some strange not-quite-checked-out state in a submodule. Try and fix this by force deinitialising everything before initialising (this will not throw away downloaded objects, git will skip them on the next attempt at cloning).

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

Nice idea, thanks @aidanhs!

@bors
Copy link
Contributor

bors commented Jan 14, 2017

📌 Commit 7b6c2cb has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 15, 2017

⌛ Testing commit 7b6c2cb with merge 20ba64d...

bors added a commit that referenced this pull request Jan 15, 2017
If submodule init fails, try from scratch

See #39051

I wonder if the cause could be some strange not-quite-checked-out state in a submodule. Try and fix this by force deinitialising everything before initialising (this will not throw away downloaded objects, git will skip them on the next attempt at cloning).

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Jan 15, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 20ba64d to master...

@bors bors merged commit 7b6c2cb into rust-lang:master Jan 15, 2017
@aidanhs aidanhs deleted the aphs-deinit-before-init branch January 18, 2017 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants