(Shot at) Fix endian bugs in i128 intrinsic impls #39094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Since the buildbots do not run tests for powerpc, its hard to add tests (and the current tests would’ve caught the problem); I will manually check whether the issue #39061 gets fixed once nightlies with this commit come out. EDIT: would be nice to get |
eddyb
approved these changes
Jan 16, 2017
|
@bors r+ p=1 |
|
📌 Commit c032bbf has been approved by |
|
⌛ Testing commit c032bbf with merge ce4223b... |
|
💔 Test failed - status-travis |
|
Failure not caused by this PR. |
|
@bors retry |
|
⌛ Testing commit c032bbf with merge 59f5a0c... |
|
💔 Test failed - status-travis |
|
… On Mon, Jan 16, 2017 at 7:51 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/192396743>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#39094 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95CljSERRgUSwImsB2Lpg8LHYrsMjks5rS5HwgaJpZM4LkWAI>
.
|
bors
added a commit
that referenced
this pull request
Jan 16, 2017
(Shot at) Fix endian bugs in i128 intrinsic impls Attempt to fix the endianness issues on big-endian machines such as power pc. Could not test if it actually makes stuff work on the powerpc, because setting up cross-compiler for ppc seems to be nigh-impossible on arch.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the endianness issues on big-endian machines such as power pc. Could not test if it actually makes stuff work on the powerpc, because setting up cross-compiler for ppc seems to be nigh-impossible on arch.