Tell emscripten to remove exception handling code when panic=abort #39193
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -712,6 +713,11 @@ fn link_natively(sess: &Session, | |||
| cmd.arg(root.join(obj)); | |||
| } | |||
|
|
|||
| if sess.target.target.options.is_like_emscripten && | |||
| sess.panic_strategy() == PanicStrategy::Abort { | |||
| cmd.arg("-s DISABLE_EXCEPTION_CATCHING=1"); | |||
There was a problem hiding this comment.
I think this'll want to get passed as two separate arguments, right? (right now this is just being passed as one)
There was a problem hiding this comment.
Yep, you are right. Will fix.
|
r? @brson |
|
@bors: r+ |
|
📌 Commit 24cb5b7 has been approved by |
…xcrichton Tell emscripten to remove exception handling code when panic=abort Fixes rust-lang#36900
Fixes #36900