-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gate Tests] - marking feature tests #39243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cseale you should remove those tests from the whitelist: rust/src/tools/tidy/src/features.rs Lines 168 to 175 in 6fe2371
|
Removal of the lang feature gate tests whitelist rust-lang#39059 r? @est31
@est31 done |
est31
approved these changes
Jan 22, 2017
@bors r=est31 |
📌 Commit ddb6027 has been approved by |
⌛ Testing commit ddb6027 with merge a8fa310... |
20 tasks
☀️ Test successful - status-appveyor, status-travis |
Merged
Its merged. Thanks @cseale ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of the lang feature gate tests whitelist #39059
r? @est31