Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for E0117 #39306

Merged
merged 1 commit into from
Jan 28, 2017
Merged

Add note for E0117 #39306

merged 1 commit into from
Jan 28, 2017

Conversation

GuillaumeGomez
Copy link
Member

Fixes #39249.

I just applied the suggestion of @durka since I don't see anything else to add.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member

eddyb commented Jan 25, 2017

Could you add a test? r=me otherwise

@bors rollup

@GuillaumeGomez
Copy link
Member Author

Sorry forgot to add them. Updated.

@bors r=eddyb rollup

@bors
Copy link
Contributor

bors commented Jan 26, 2017

📌 Commit 1769f80 has been approved by eddyb

@durka
Copy link
Contributor

durka commented Jan 26, 2017

Travis failure looks real.

error: /checkout/src/test/compile-fail/coherence-impls-copy.rs:48: unexpected "note": '48:1: 48:26: the impl does not reference any types defined in this crate'

error: /checkout/src/test/compile-fail/coherence-impls-copy.rs:48: unexpected "note": '48:1: 48:26: define and implement a trait or new type instead'

error: /checkout/src/test/compile-fail/coherence-impls-copy.rs:42: expected note not found: define and implement a trait or new type instead

error: /checkout/src/test/compile-fail/coherence-impls-copy.rs:42: expected note not found: the impl does not reference any types defined in this crate

I guess the order of the notes matters?

@GuillaumeGomez
Copy link
Member Author

Ok, fixed (very weird case). Thanks for the notification @durka!

@bors: r=eddyb rollup

@bors
Copy link
Contributor

bors commented Jan 26, 2017

📌 Commit eaf182e has been approved by eddyb

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 28, 2017
Add note for E0117

Fixes rust-lang#39249.

I just applied the suggestion of @durka since I don't see anything else to add.
bors added a commit that referenced this pull request Jan 28, 2017
@bors bors merged commit eaf182e into rust-lang:master Jan 28, 2017
@GuillaumeGomez GuillaumeGomez deleted the newtype_help branch January 28, 2017 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants