-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note for E0117 #39306
Merged
Merged
Add note for E0117 #39306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
Could you add a test? r=me otherwise @bors rollup |
GuillaumeGomez
force-pushed
the
newtype_help
branch
from
January 26, 2017 00:34
88557e8
to
1769f80
Compare
Sorry forgot to add them. Updated. @bors r=eddyb rollup |
📌 Commit 1769f80 has been approved by |
Travis failure looks real.
I guess the order of the notes matters? |
GuillaumeGomez
force-pushed
the
newtype_help
branch
from
January 26, 2017 11:09
1769f80
to
eaf182e
Compare
📌 Commit eaf182e has been approved by |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 28, 2017
Add note for E0117 Fixes rust-lang#39249. I just applied the suggestion of @durka since I don't see anything else to add.
bors
added a commit
that referenced
this pull request
Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39249.
I just applied the suggestion of @durka since I don't see anything else to add.