Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use "unadjusted" ABI on non windows platforms #39472

Merged
merged 1 commit into from
Feb 5, 2017

Conversation

est31
Copy link
Member

@est31 est31 commented Feb 2, 2017

We introduced the unadjusted ABI to work around wrong
(buggy) ABI expectations by LLVM on Windows [1].
Therefore, it should be solely used on Windows and not
on other platforms, like right now is the case.

[1]: see this comment for details #38482 (comment)

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@est31
Copy link
Member Author

est31 commented Feb 2, 2017

I want this change not just for the cleanup but also so that if it is not harmless, bors will yell at me now, and not later when libcompiler-builtins gets merged where it might be much harder to find out that this is the cause of the issues.

@eddyb
Copy link
Member

eddyb commented Feb 2, 2017

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Feb 2, 2017

📌 Commit a163c34 has been approved by nagisa

@bors
Copy link
Contributor

bors commented Feb 4, 2017

☔ The latest upstream changes (presumably #39463) made this pull request unmergeable. Please resolve the merge conflicts.

We introduced the unadjusted ABI to work around wrong
(buggy) ABI expectations by LLVM on Windows [1].
Therefore, it should be solely used on Windows and not
on other platforms, like right now is the case.

[1]: see this comment for details rust-lang#38482 (comment)
@eddyb
Copy link
Member

eddyb commented Feb 4, 2017

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Feb 4, 2017

📌 Commit 3c16139 has been approved by nagisa

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
…gisa

Don't use "unadjusted" ABI on non windows platforms

We introduced the unadjusted ABI to work around wrong
(buggy) ABI expectations by LLVM on Windows [1].
Therefore, it should be solely used on Windows and not
on other platforms, like right now is the case.

[1]: see this comment for details rust-lang#38482 (comment)
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
…gisa

Don't use "unadjusted" ABI on non windows platforms

We introduced the unadjusted ABI to work around wrong
(buggy) ABI expectations by LLVM on Windows [1].
Therefore, it should be solely used on Windows and not
on other platforms, like right now is the case.

[1]: see this comment for details rust-lang#38482 (comment)
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 5, 2017
…gisa

Don't use "unadjusted" ABI on non windows platforms

We introduced the unadjusted ABI to work around wrong
(buggy) ABI expectations by LLVM on Windows [1].
Therefore, it should be solely used on Windows and not
on other platforms, like right now is the case.

[1]: see this comment for details rust-lang#38482 (comment)
bors added a commit that referenced this pull request Feb 5, 2017
Rollup of 12 pull requests

- Successful merges: #39439, #39472, #39481, #39491, #39501, #39509, #39514, #39519, #39526, #39528, #39530, #39538
- Failed merges:
@bors bors merged commit 3c16139 into rust-lang:master Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants