continue to prefer hyphens in test files named after issue numbers #39556
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 1c26f8c has been approved by |
…oogaloo, r=petrochenkov continue to prefer hyphens in test files named after issue numbers a [followup](rust-lang#38473 (comment)) to rust-lang#38473 (The files in `auxillary/` directories have an excuse, as they get used as crates/modules, for which snake_case names make more sense.)
|
😰 Oops; I thought I was smart enough to do the issue-32829 edit correctly and let Travis check my work rather than wait for the tests to run locally, but I was wrong. Sorry for the inconvenience @frewsxcv! Will fix tomorrow. |
zackmdavis
force-pushed
the
issue_kebab_2_electric_boogaloo
branch
from
1c26f8c
to
102fc6a
Compare
|
@zackmdavis gah sorry for the delay here! Looks like there's some failures on CI though? Mind fixing and I'll r+? |
Mark-Simulacrum
added
the
S-waiting-on-author
|
Hi @zackmdavis! Just a friendly ping-- are you still up for making the changes to get the tests to pass? Let us know if you need any help or have any questions! |
|
@carols10cents hi, Carole! Thanks for asking! I'm kind of recovering from a personal crisis that I'm tempted to explain in this comment because humans are social animals, but which it turns out that I shouldn't actually explain, because you have no particular reason to care about that because the thing that you asked about was the status of this pull request! I think we should close the pull request, because while it would be desirable to tidy up the hyphens in the test file names, it's more important to keep the queue of open pull requests tidy; I can reopen or file another pull request later if I get around to it. |
|
@zackmdavis no worries! As a social animal, I hope that you're doing better and I'm sending good thoughts your way ❤️ |
a followup to #38473
(The files in
auxillary/directories have an excuse, as they get used as crates/modules, for which snake_case names make more sense.)