-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete more swaths of the configure script #39770
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #40091) made this pull request unmergeable. Please resolve the merge conflicts. |
070bd28
to
bfd2f5b
Compare
elif cputype == 's390x': | ||
cputype = 's390x' | ||
elif cputype == 'BePC': | ||
cputype = 'i686' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'BePC' really? where did this come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I run Haiku at home and Rust won't bootstrap otherwise.
@bors r+ |
📌 Commit bfd2f5b has been approved by |
🔒 Merge conflict |
@bors: retry |
Delete more swaths of the configure script This PR deletes more swaths of the `./configure` script which are either no longer necessary or already available in rustbuild (where an implementation is preferred)
bfd2f5b
to
cd23f1c
Compare
@bors: r=brson |
📌 Commit cd23f1c has been approved by |
Delete more swaths of the configure script This PR deletes more swaths of the `./configure` script which are either no longer necessary or already available in rustbuild (where an implementation is preferred)
cd23f1c
to
3acaf21
Compare
@bors: r=brson |
📌 Commit 3acaf21 has been approved by |
3acaf21
to
ade8f29
Compare
@bors: r=brson |
📌 Commit ade8f29 has been approved by |
☔ The latest upstream changes (presumably #40432) made this pull request unmergeable. Please resolve the merge conflicts. |
This is all in rustbuild already.
This is all not used any more
All of these should be handled by rustbuild in sanity.rs right now.
All of this should already be vendored in rustbuild if necessary or otherwise it's just not used.
This is not used any more
None of this is used by rustbuild any more
This commit removes detection of CFG_OSTYPE and CFG_CPUTYPE from the configure script, which means that the default value of `--build` is no longer present in the configure script. All this logic is now available in rustbuild itself, so there's no need to duplicate it.
ade8f29
to
f8ca805
Compare
@bors: r=brson |
📌 Commit f8ca805 has been approved by |
⌛ Testing commit f8ca805 with merge 244c45b... |
💔 Test failed - status-travis |
@bors: retry
* network slowness
…On Sat, Mar 11, 2017 at 4:22 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/210138426>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39770 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95AYW1WYtR7EqleSQ6o0rKy3aXKVbks5rkx6QgaJpZM4L-ljs>
.
|
Delete more swaths of the configure script This PR deletes more swaths of the `./configure` script which are either no longer necessary or already available in rustbuild (where an implementation is preferred)
☀️ Test successful - status-appveyor, status-travis |
cputype = 'arm' | ||
ostype += 'eabihf' | ||
elif cputype == 'armv7l': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cputype is also in the list at new line 472
This PR deletes more swaths of the
./configure
script which are either no longer necessary or already available in rustbuild (where an implementation is preferred)