-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding compile fail test for staged_api feature #39772
Conversation
No, tests in the compile-fail suite are expected to fail compilation, but it will show up to you as "success". You need to tell it about the error messages that were excepted, if it encounters errors that didn't match it fails, which probably happened here. For how to mark the errors, you should read COMPILER_TESTS.md. Also, you can have a look at how #39700 did it.
Run-pass is for tests that are expected to be compiled and not panic or segfault when they run, and compile-fail is for tests that fail to compile. There are other test suites as well, like parse-fail for tests that fail much earlier in compilation, during parsing. Usually though tests are in compile-fail and not parse-fail. |
e56d130
to
3a54eee
Compare
3a54eee
to
07b3a8b
Compare
@bors delegate=est32 |
✌️ @est32 can now approve this pull request |
Helps if I get the user name right... @bors delegate=est31 |
✌️ @est31 can now approve this pull request |
@bors r=est31 |
📌 Commit 07b3a8b has been approved by |
…, r=est31 Adding compile fail test for staged_api feature Issue rust-lang#39059 r? @est31 @est31 running the tests for this feature fails. Is that expected since this is the `compile-fail`suite? I copied this test from the run-pass suite: `rust/src/test/run-pass/reachable-unnameable-type-alias.rs`. What are the differences between these suites in operation and why they are used?
…, r=est31 Adding compile fail test for staged_api feature Issue rust-lang#39059 r? @est31 @est31 running the tests for this feature fails. Is that expected since this is the `compile-fail`suite? I copied this test from the run-pass suite: `rust/src/test/run-pass/reachable-unnameable-type-alias.rs`. What are the differences between these suites in operation and why they are used?
Issue #39059
r? @est31
@est31 running the tests for this feature fails. Is that expected since this is the
compile-fail
suite?I copied this test from the run-pass suite:
rust/src/test/run-pass/reachable-unnameable-type-alias.rs
. What are the differences between these suites in operation and why they are used?