-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor suggestions into a structured form internally #39973
Conversation
… as just another error type
Even though this is not user-visible, I still don't think it is an improvement to add another category of diagnostic to the compiler. As I stated on #39458 I don't think there is any benefit to the guess category. @rust-lang/compiler thoughts? Do you want another category of diagnostic? |
Since I disagree and discussing this in an ad-hoc manner (like in #39458) probably won't lead anywhere, would you prefer if I'd open an RFC to have a clean base for discussion?
Since json is stable, it is user-visible. |
cc @estebank |
I guess this doesn't really affect the output? |
Sure, seems like a good idea - we haven't had a compiler RFC for a while |
I think rust-lang/rfcs#1941 is the corresponding RFC for this now, right? I'm going to close this but if I'm incorrect then just let me know and I'll reopen! |
work towards making #39458 possible without user visible changes.
This PR changes suggestions from being converted to regular diagnostics by the
span_suggestion
call, and instead moves this to theemit
call on the specific emitter (json or command line).r? @nrc
cc @petrochenkov