Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] TEMPORARY CI bisect helper for #40008. #40114

Closed
wants to merge 18 commits into from
Closed

[DO NOT MERGE] TEMPORARY CI bisect helper for #40008. #40114

wants to merge 18 commits into from

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Feb 26, 2017 •
edited
Loading

First attempt (IMAGE=linux-tested-targets ALLOW_PR=1, without DEPLOY=1, which was wrong):

  • (run-pass=527s) [28f1cf4] rustc_typeck: don't use Result for get_type_parameter_bounds ...
  • (run-pass=531s) [ba11640] rustc_typeck: hook up collect and item/body check to on-demand.
  • (run-pass=523s) [d9f0a94] rustc_const_eval: demand that the MIR qualify_consts ran ...

Second attempt (IMAGE=linux-tested-targets ALLOW_PR=1 DEPLOY=1):

  • (run-pass=1231s) [d9f0a94] rustc_const_eval: demand that the MIR qualify_consts ran ...
  • (run-pass=884s) [28f1cf4] rustc_typeck: don't use Result for get_type_parameter_bounds ...
  • (run-pass=1028s) [ba11640] rustc_typeck: hook up collect and item/body check to on-demand.
  • (run-pass=800s) [3146ee8] rustc: simplify tcx.closure_type(...) as it can copy the cached values.
  • (run-pass=852s) [9c3c306] rustc_typeck: move the leaves (generics, trait_def, adt_def) to on-demand.

Third attempt (same as [d9f0a94] from the second attempt, but with tweaks):

  • (run-pass=1231s) commented out --enable-llvm-static-stdcpp

@eddyb
rustc: store type parameter defaults outside of ty::Generics.
e8d01ea
@eddyb
rustc_typeck: simplify AstConv requests as implemented by collect.
86e4029
@eddyb
rustc: move the actual values of enum discriminants into a map.
e96a171
@eddyb
rustc: consolidate dep-tracked hashmaps in tcx.maps.
cc8a3a9
@eddyb
rustc: introduce a query system for type information in ty::maps.
b5c4244
@eddyb
rustc_mir: expose MIR building through ty::maps::Provider.
374ea14
@eddyb
rustc_typeck: lift CrateCtxt to TyCtxt.
4649f73
@eddyb
rustc_typeck: don't use Result for get_type_parameter_bounds and ensu…
28f1cf4 
…re_super_predicates.
@eddyb
rustc: combine BareFnTy and ClosureTy into FnSig.
91374f8
@eddyb
rustc: simplify tcx.closure_type(...) as it can copy the cached values.
3146ee8
@eddyb
rustc_typeck: move the leaves (generics, trait_def, adt_def) to on-de…
9c3c306 
…mand.
@eddyb
rustc_typeck: hook up collect and item/body check to on-demand.
ba11640
@eddyb
rustc: allow handling cycle errors gracefully in on-demand.
9890e04
@eddyb
rustc_typeck: rework coherence to be almost completely on-demand.
c832e6f
@eddyb
rustc_const_eval: always demand typeck_tables for evaluating constants.
e7a4882
@eddyb
rustc_const_eval: demand that the MIR qualify_consts ran on each eval…
d9f0a94 
…uated body.
@eddyb eddyb unassigned nrc Feb 26, 2017
@eddyb eddyb force-pushed the lazy-12-bisect branch 8 times, most recently from 44f8f1a to deb985b Compare February 27, 2017 00:15
@eddyb eddyb mentioned this pull request Feb 27, 2017
Merged
@eddyb
index on lazy-12-bisect: d9f0a94 rustc_const_eval: demand that the MI…
da50c2e 
…R qualify_consts ran on each evaluated body.
@eddyb
WIP on lazy-12-bisect: d9f0a94 rustc_const_eval: demand that the MIR …
46b1296 
…qualify_consts ran on each evaluated body.
@eddyb
Copy link
Member Author

eddyb commented Feb 27, 2017

Suspect found: -Zsave-analysis-api doubles the size of metadata in libraries.

@eddyb eddyb closed this Feb 27, 2017
@eddyb eddyb deleted the lazy-12-bisect branch February 27, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyb @nrc