Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing docs and examples for fmt::Write #40126

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Add missing docs and examples for fmt::Write #40126

merged 1 commit into from
Feb 28, 2017

Conversation

GuillaumeGomez
Copy link
Member

@frewsxcv
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 27, 2017

📌 Commit 88d62df has been approved by frewsxcv

TimNN
TimNN reviewed Feb 27, 2017
View reviewed changes
src/libcore/fmt/mod.rs Outdated
/// use std::fmt::{Error, Write};
///
/// fn writer<W: Write>(f: &mut W, c: char) -> Result<(), Error> {
/// f.write_char(s)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be f.write_char(c).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

@frewsxcv
Copy link
Member

@bors r-

@frewsxcv
Copy link
Member

r=me with the fixed error

@frewsxcv frewsxcv removed their assignment Feb 28, 2017
@GuillaumeGomez
Copy link
Member Author

@bors: r=frewsxcv rollup

@bors
Copy link
Contributor

bors commented Feb 28, 2017

📌 Commit 5933560 has been approved by frewsxcv

@eddyb eddyb mentioned this pull request Feb 28, 2017
Closed
eddyb added a commit to eddyb/rust that referenced this pull request Feb 28, 2017
@eddyb
Rollup merge of rust-lang#40126 - GuillaumeGomez:fmt-write-docs, r=fr…
e640c79 
…ewsxcv

Add missing docs and examples for fmt::Write

r? @frewsxcv
@eddyb eddyb mentioned this pull request Feb 28, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 28, 2017
@frewsxcv
Rollup merge of rust-lang#40126 - GuillaumeGomez:fmt-write-docs, r=fr…
c4b6c98 
…ewsxcv

Add missing docs and examples for fmt::Write

r? @frewsxcv
@frewsxcv frewsxcv mentioned this pull request Feb 28, 2017
Merged
bors added a commit that referenced this pull request Feb 28, 2017
@bors
Auto merge of #40148 - frewsxcv:rollup, r=frewsxcv
be76056 
Rollup of 9 pull requests

- Successful merges: #39977, #40033, #40047, #40056, #40057, #40122, #40124, #40126, #40131
- Failed merges: #40101
@bors bors merged commit 5933560 into rust-lang:master Feb 28, 2017
@GuillaumeGomez GuillaumeGomez deleted the fmt-write-docs branch February 28, 2017 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimNN TimNN TimNN left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @frewsxcv @bors @TimNN