rustbuild: Assert directory creation succeeds #40337
Conversation
I've been seeing failures on the bots when building jemalloc and my assumption is that it's because cwd isn't created. That may be possible if this `create_dir_all` call change in this commit fails, in which case we ignore the error. This commit updates the location to call `create_dir_racy` which handles concurrent invocations, as multiple build scripts may be trying to create the `native` dir.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
another instance of this failure happened at https://travis-ci.org/rust-lang/rust/jobs/208686112 and I'm hoping this'll fix it. Unfortunately I can't reproduce locally so this is just a guess to a fix. |
|
@bors r+ Awesome function. |
|
📌 Commit e412af2 has been approved by |
|
My best guess is that maybe several processes try to create the |
|
@petrochenkov yes that's my belief as well. I didn't find a great spot to create the dir ahead of time so I just left it here |
rustbuild: Assert directory creation succeeds I've been seeing failures on the bots when building jemalloc and my assumption is that it's because cwd isn't created. That may be possible if this `create_dir_all` call change in this commit fails, in which case we ignore the error. This commit updates the location to call `create_dir_racy` which handles concurrent invocations, as multiple build scripts may be trying to create the `native` dir.
rustbuild: Assert directory creation succeeds I've been seeing failures on the bots when building jemalloc and my assumption is that it's because cwd isn't created. That may be possible if this `create_dir_all` call change in this commit fails, in which case we ignore the error. This commit updates the location to call `create_dir_racy` which handles concurrent invocations, as multiple build scripts may be trying to create the `native` dir.
|
⌛ Testing commit e412af2 with merge 0806855... |
|
💔 Test failed - status-travis |
|
@bors: retry
|
rustbuild: Assert directory creation succeeds I've been seeing failures on the bots when building jemalloc and my assumption is that it's because cwd isn't created. That may be possible if this `create_dir_all` call change in this commit fails, in which case we ignore the error. This commit updates the location to call `create_dir_racy` which handles concurrent invocations, as multiple build scripts may be trying to create the `native` dir.
|
☀️ Test successful - status-appveyor, status-travis |
I've been seeing failures on the bots when building jemalloc and my assumption
is that it's because cwd isn't created. That may be possible if this
create_dir_allcall change in this commit fails, in which case we ignore theerror.
This commit updates the location to call
create_dir_racywhich handlesconcurrent invocations, as multiple build scripts may be trying to create the
nativedir.