Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 13 pull requests #40440

Closed
wants to merge 34 commits into from
Closed

Rollup of 13 pull requests #40440

wants to merge 34 commits into from

Conversation

bjorn3 and others added 30 commits February 28, 2017 10:57
Fixes rendering of the end of the `Configure and Make` section.
Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway.
gdb will now reliably detect the lanugage as rust even before any
code is run.
This commit adds the entry `"fma\0"` to the whitelist for the x86
target. LLVM already supports fma but rustc did not directly. Previously
rustc permitted `+fma` in the target-feature argument and enabled the use
of FMA instructions, but it did not list it in the configuration and
attributes.

fixes rust-lang#40406
… r=frewsxcv

Add missing example for Display::fmt

r? @frewsxcv
Allow lints to check Bodys directly

r? @eddyb

babysteps towards fixing https://github.com/Manishearth/rust-clippy/issues/1580 (disable certain lints in const environments, since they make no sense there (yet))
…r=nikomatsakis

Disallow subtyping between T and U in T: Unsize<U>.

Because `&mut T` can be coerced to `&mut U`, `T` and `U` must be unified invariantly. Fixes rust-lang#40288.
E.g. coercing `&mut [&'a X; N]` to `&mut [&'b X]` must require `'a` be equal to `'b`, otherwise you can convert between `&'a X` and `&'b X` (in either direction), potentially unsoundly lengthening lifetimes.

Subtyping here was introduced with `Unsize` in rust-lang#24619 (landed in 1.1, original PR is rust-lang#23785).
save-analysis: cope with lack of method data after a type error

Fixes rust-lang#39957

r? @eddyb
Fix missing backtick typo

Fixes rendering of the end of the `Configure and Make` section.
Improve the LLVM IR we generate for trivial functions, especially #[naked] ones.

These two small changes fix edef1c/libfringe#68:
* Don't emit ZST allocas, such as when returning `()`
* Don't emit a branch from LLVM's entry block to MIR's `START_BLOCK` unless needed
  * That is, if a loop branches back to it, although I'm not sure that's even valid MIR
Do not bother creating StorageLive for TyNever

Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway.

r? @eddyb
Ariel Ben-Yehuda added 4 commits March 11, 2017 17:13
emit !align attributes on stores of operand pairs

This avoids another case of missing-align UB. cc rust-lang#40373

r? @eddyb
Update gdbr tests

gdb will now reliably detect the lanugage as rust even before any code is run.
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr

Hello!

This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory.

Thanks to @nikomatsakis and @eddyb
rustc: Whitelist the FMA target feature

This commit adds the entry `"fma\0"` to the whitelist for the x86
target. LLVM already supports fma but rustc did not directly. Previously
rustc permitted `+fma` in the target-feature argument and enabled the use
of FMA instructions, but it did not list it in the configuration and
attributes.

fixes rust-lang#40406
@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor Author

arielb1 commented Mar 11, 2017

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Mar 11, 2017

📌 Commit effb66c has been approved by arielb1

@bors
Copy link
Contributor

bors commented Mar 11, 2017

⌛ Testing commit effb66c with merge 9db4d87...

@bors
Copy link
Contributor

bors commented Mar 11, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Mar 11, 2017 via email

@alexcrichton
Copy link
Member

@bors: p=3

@bors
Copy link
Contributor

bors commented Mar 11, 2017

⌛ Testing commit effb66c with merge 9ca8831...

bors added a commit that referenced this pull request Mar 11, 2017
Rollup of 13 pull requests

- Successful merges: #40146, #40299, #40315, #40319, #40344, #40345, #40367, #40372, #40373, #40385, #40400, #40404, #40431
- Failed merges:
@bors
Copy link
Contributor

bors commented Mar 11, 2017

💔 Test failed - status-travis

@arielb1
Copy link
Contributor Author

arielb1 commented Mar 11, 2017

---- [debuginfo-gdb] debuginfo-gdb/macro-stepping.rs stdout ----
	NOTE: compiletest thinks it is using GDB without native rust support
NOTE: compiletest thinks it is using GDB version 7011001

error: line not found in debugger output: [...]#inc-loc1[...]

@alexcrichton
Copy link
Member

@arielb1 my guess is #40367 but that's mostly a complete guess

@arielb1
Copy link
Contributor Author

arielb1 commented Mar 11, 2017

Sure
Looks like https://bugs.llvm.org/show_bug.cgi?id=32123

@arielb1
Copy link
Contributor Author

arielb1 commented Mar 11, 2017

I'll test that locally.

@arielb1 arielb1 closed this Mar 11, 2017
@arielb1 arielb1 reopened this Mar 11, 2017
@arielb1 arielb1 closed this Mar 11, 2017
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.