Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #40446

Merged
merged 33 commits into from
Mar 12, 2017
Merged

Rollup of 12 pull requests #40446

merged 33 commits into from
Mar 12, 2017

Conversation

bjorn3 and others added 30 commits February 28, 2017 10:57
Fixes rendering of the end of the `Configure and Make` section.
Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway.
gdb will now reliably detect the lanugage as rust even before any
code is run.
This commit adds the entry `"fma\0"` to the whitelist for the x86
target. LLVM already supports fma but rustc did not directly. Previously
rustc permitted `+fma` in the target-feature argument and enabled the use
of FMA instructions, but it did not list it in the configuration and
attributes.

fixes rust-lang#40406
This should hopefully add support for debugging OSX and Windows presumed sccache
failures instead of just the Linux ones.
… r=frewsxcv

Add missing example for Display::fmt

r? @frewsxcv
Allow lints to check Bodys directly

r? @eddyb

babysteps towards fixing https://github.com/Manishearth/rust-clippy/issues/1580 (disable certain lints in const environments, since they make no sense there (yet))
…r=nikomatsakis

Disallow subtyping between T and U in T: Unsize<U>.

Because `&mut T` can be coerced to `&mut U`, `T` and `U` must be unified invariantly. Fixes rust-lang#40288.
E.g. coercing `&mut [&'a X; N]` to `&mut [&'b X]` must require `'a` be equal to `'b`, otherwise you can convert between `&'a X` and `&'b X` (in either direction), potentially unsoundly lengthening lifetimes.

Subtyping here was introduced with `Unsize` in rust-lang#24619 (landed in 1.1, original PR is rust-lang#23785).
save-analysis: cope with lack of method data after a type error

Fixes rust-lang#39957

r? @eddyb
Fix missing backtick typo

Fixes rendering of the end of the `Configure and Make` section.
Do not bother creating StorageLive for TyNever

Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway.

r? @eddyb
Update gdbr tests

gdb will now reliably detect the lanugage as rust even before any code is run.
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr

Hello!

This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory.

Thanks to @nikomatsakis and @eddyb
@bors
Copy link
Contributor

bors commented Mar 11, 2017

💔 Test failed - status-travis

@arielb1
Copy link
Contributor Author

arielb1 commented Mar 11, 2017

Cloning into '/home/travis/build/rust-lang/rust/src/llvm'...

No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.

Network failure

@bors retry

@bors
Copy link
Contributor

bors commented Mar 11, 2017

⌛ Testing commit b1e03fe with merge 4674a74...

@bors
Copy link
Contributor

bors commented Mar 11, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Mar 11, 2017 via email

@alexcrichton
Copy link
Member

@bors: p=2

@bors
Copy link
Contributor

bors commented Mar 12, 2017

⌛ Testing commit b1e03fe with merge bf4151b...

@bors
Copy link
Contributor

bors commented Mar 12, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Mar 12, 2017

⌛ Testing commit b1e03fe with merge 9ae5edd...

@bors
Copy link
Contributor

bors commented Mar 12, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 12, 2017

📌 Commit 6a5fd0f has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Mar 12, 2017

⌛ Testing commit 6a5fd0f with merge 744e696...

bors added a commit that referenced this pull request Mar 12, 2017
Rollup of 12 pull requests

- Successful merges: #40146, #40299, #40315, #40319, #40344, #40345, #40372, #40373, #40400, #40404, #40419, #40431
- Failed merges:
@bors
Copy link
Contributor

bors commented Mar 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 744e696 to master...

@bors bors merged commit 6a5fd0f into rust-lang:master Mar 12, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 20, 2017
I have a suspicion that this caused a large regression in cycle times by forcing
the compiler to perform more checks on every `debug!` statement, so let's test
this out by removing the `RUST_LOG` env var globally.

This regression in cycle time was witnessed between [two] [builds] where the
[PR] in question didn't do much suspicious. Judging by how the stage0 times
*also* regressed though then this is my best guess.

[two]: https://travis-ci.org/rust-lang/rust/builds/210149932
[builds]: https://travis-ci.org/rust-lang/rust/builds/210179995
[PR]: rust-lang#40446
bors added a commit that referenced this pull request Mar 21, 2017
travis: Don't set `RUST_LOG` globally

I have a suspicion that this caused a large regression in cycle times by forcing
the compiler to perform more checks on every `debug!` statement, so let's test
this out by removing the `RUST_LOG` env var globally.

This regression in cycle time was witnessed between [two] [builds] where the
[PR] in question didn't do much suspicious. Judging by how the stage0 times
*also* regressed though then this is my best guess.

[two]: https://travis-ci.org/rust-lang/rust/builds/210149932
[builds]: https://travis-ci.org/rust-lang/rust/builds/210179995
[PR]: #40446
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.