Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gcc used for dist-x86-linux builds #40617

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Update gcc used for dist-x86-linux builds #40617

merged 1 commit into from
Mar 23, 2017

Conversation

TimNN
Copy link
Contributor

@TimNN TimNN commented Mar 17, 2017

GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.

r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).

@alexcrichton
Copy link
Member

r=me when it's green

@TimNN
Copy link
Contributor Author

TimNN commented Mar 18, 2017

The build was killed during openssl install, that didn't reproduce locally so I have restarted the travis build.

@TimNN
Copy link
Contributor Author

TimNN commented Mar 18, 2017

The build timed out again.

@alexcrichton
Copy link
Member

That looks like it got plenty far enough though to verify this works, want to send it to bors?

@TimNN
Copy link
Contributor Author

TimNN commented Mar 19, 2017

@alexcrichton: Sure, I removed the test commit.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 19, 2017

📌 Commit 09d12d0 has been approved by alexcrichton

@frewsxcv frewsxcv mentioned this pull request Mar 19, 2017
Closed
@ishitatsuyuki
Copy link
Contributor

The base, CentOS 5 is about to expire; why not just upgrade to a decent distro?

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 20, 2017
@frewsxcv
Rollup merge of rust-lang#40617 - TimNN:dist-update-gcc, r=alexcrichton
da08827 
Update gcc used for dist-x86-linux builds

GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.

r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).
@frewsxcv frewsxcv mentioned this pull request Mar 20, 2017
Closed
@bors
Copy link
Contributor

bors commented Mar 21, 2017

🔒 Merge conflict

@TimNN
Copy link
Contributor Author

TimNN commented Mar 21, 2017

rebased

@alexcrichton
Copy link
Member

@bors: r+

(feel free to @bors: r=alexcrichton whenever you rebase)

@bors
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit 88d5645 has been approved by `alexcrichton``

@bors
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit 88d5645 has been approved by alexcrichton

@TimNN
Copy link
Contributor Author

TimNN commented Mar 21, 2017

@alexcrichton: I don't think I have bors rights, so bors: r=alexcrichton wouldn't work, right?

@alexcrichton
Copy link
Member

Whoa sorry I had no idea!

Now you've got r+ :)

@alexcrichton
Copy link
Member

or rather, after I deploy that

@TimNN
Copy link
Contributor Author

TimNN commented Mar 21, 2017

@alexcrichton: Thanks!

@cuviper
Copy link
Member

cuviper commented Mar 21, 2017

The base, CentOS 5 is about to expire; why not just upgrade to a decent distro?

Let's leave out subjective assessments of what's "decent" please. It matters to keep the base OS old for maximum ABI compatibility, so when we do move, the next logical choice would be CentOS 6.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 22, 2017
@frewsxcv
Rollup merge of rust-lang#40617 - TimNN:dist-update-gcc, r=alexcrichton
c5f3bf1 
Update gcc used for dist-x86-linux builds

GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.

r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).
@frewsxcv frewsxcv mentioned this pull request Mar 22, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 23, 2017
@frewsxcv
Rollup merge of rust-lang#40617 - TimNN:dist-update-gcc, r=alexcrichton
a419ce9 
Update gcc used for dist-x86-linux builds

GCC 4.7 is too old to build LLVM 4.0, so this PR updates to 4.8.

r? @alexcrichton (I'll ping you again once travis is green and the test commit is removed).
@frewsxcv frewsxcv mentioned this pull request Mar 23, 2017
Merged
bors added a commit that referenced this pull request Mar 23, 2017
@bors
Auto merge of #40752 - frewsxcv:rollup, r=frewsxcv
7c7753d 
Rollup of 6 pull requests

- Successful merges: #39891, #40518, #40542, #40617, #40678, #40696
- Failed merges:
@bors bors merged commit 88d5645 into rust-lang:master Mar 23, 2017
@TimNN TimNN deleted the dist-update-gcc branch March 23, 2017 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TimNN @alexcrichton @bors @ishitatsuyuki @cuviper