Revert #39485, fixing type-inference regressions #40636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
added
the
beta-nominated
|
Note: I haven't had time to fully test this. =) Gotta run, but I've got a build going and will check back in. |
|
@bors r+ |
|
📌 Commit f2150ae has been approved by |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #40693) made this pull request unmergeable. Please resolve the merge conflicts. |
nikomatsakis
force-pushed
the
revert-39485
branch
from
f2150ae
to
0f1eb8a
Compare
|
@bors r=eddyb |
|
📌 Commit 0f1eb8a has been approved by |
nikomatsakis
added
the
beta-accepted
|
Marking as beta-accepted. Small patch, minimal risk, regression. cc @rust-lang/compiler |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 24, 2017
Revert rust-lang#39485, fixing type-inference regressions This reverts PR rust-lang#39485, which should fix the immediate regressions. Eventually I'd like to land rust-lang#40224 -- or some variant of it -- which revisits the question fo dead-code and inference. r? @eddyb cc @canndrew
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Mar 24, 2017
Revert rust-lang#39485, fixing type-inference regressions This reverts PR rust-lang#39485, which should fix the immediate regressions. Eventually I'd like to land rust-lang#40224 -- or some variant of it -- which revisits the question fo dead-code and inference. r? @eddyb cc @canndrew
bors
added a commit
that referenced
this pull request
Mar 24, 2017
bors
added a commit
that referenced
this pull request
Apr 1, 2017
…chton Backport #40636 to beta I suspect that this will help with #40953 but have not been able to verify for...reasons. r? @alexcrichton cc @brson
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #39485, which should fix the immediate regressions. Eventually I'd like to land #40224 -- or some variant of it -- which revisits the question fo dead-code and inference.
r? @eddyb
cc @canndrew